* [PATCH -next] libfc: needs CRC32
[not found] <20090112154539.4857f533.sfr@canb.auug.org.au>
@ 2009-01-12 18:50 ` Randy Dunlap
2009-01-13 0:05 ` Love, Robert W
2009-01-12 18:53 ` [PATCH -next] scsi_debug: needs CRC_T10DIF Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2009-01-12 18:50 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, scsi, James Bottomley, Andrew Morton
From: Randy Dunlap <randy.dunlap@oracle.com>
libfc uses crc32 functions, so cause it to be built
via select:
drivers/built-in.o: In function `fc_frame_crc_check':
(.text+0x75dae): undefined reference to `crc32_le'
drivers/built-in.o: In function `fc_fcp_recv':
fc_fcp.c:(.text+0x7b919): undefined reference to `crc32_le'
fc_fcp.c:(.text+0x7b9d5): undefined reference to `crc32_le'
fc_fcp.c:(.text+0x7ba54): undefined reference to `crc32_le'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20090112.orig/drivers/scsi/Kconfig
+++ linux-next-20090112/drivers/scsi/Kconfig
@@ -608,6 +608,7 @@ config SCSI_FLASHPOINT
config LIBFC
tristate "LibFC module"
select SCSI_FC_ATTRS
+ select CRC32
---help---
Fibre Channel library module
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] scsi_debug: needs CRC_T10DIF
[not found] <20090112154539.4857f533.sfr@canb.auug.org.au>
2009-01-12 18:50 ` [PATCH -next] libfc: needs CRC32 Randy Dunlap
@ 2009-01-12 18:53 ` Randy Dunlap
2009-01-13 3:26 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2009-01-12 18:53 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, scsi, James Bottomley, Andrew Morton, mkp
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix scsi_debug build error:
drivers/built-in.o: In function `resp_read':
scsi_debug.c:(.text+0x21379a): undefined reference to `crc_t10dif'
drivers/built-in.o: In function `resp_write':
scsi_debug.c:(.text+0x213fca): undefined reference to `crc_t10dif'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20090112.orig/drivers/scsi/Kconfig
+++ linux-next-20090112/drivers/scsi/Kconfig
@@ -1535,6 +1535,7 @@ config SCSI_NSP32
config SCSI_DEBUG
tristate "SCSI debugging host simulator"
depends on SCSI
+ select CRC_T10DIF
help
This is a host adapter simulator that can simulate multiple hosts
each with multiple dummy SCSI devices (disks). It defaults to one
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH -next] libfc: needs CRC32
2009-01-12 18:50 ` [PATCH -next] libfc: needs CRC32 Randy Dunlap
@ 2009-01-13 0:05 ` Love, Robert W
0 siblings, 0 replies; 4+ messages in thread
From: Love, Robert W @ 2009-01-13 0:05 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell
Cc: linux-next@vger.kernel.org, LKML, scsi, James Bottomley,
Andrew Morton
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> libfc uses crc32 functions, so cause it to be built
> via select:
>
> drivers/built-in.o: In function `fc_frame_crc_check':
> (.text+0x75dae): undefined reference to `crc32_le'
> drivers/built-in.o: In function `fc_fcp_recv':
> fc_fcp.c:(.text+0x7b919): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7b9d5): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7ba54): undefined reference to `crc32_le'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Robert Love <robert.w.love@intel.com>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20090112.orig/drivers/scsi/Kconfig
> +++ linux-next-20090112/drivers/scsi/Kconfig
> @@ -608,6 +608,7 @@ config SCSI_FLASHPOINT
> config LIBFC
> tristate "LibFC module"
> select SCSI_FC_ATTRS
> + select CRC32
> ---help---
> Fibre Channel library module
>
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi_debug: needs CRC_T10DIF
2009-01-12 18:53 ` [PATCH -next] scsi_debug: needs CRC_T10DIF Randy Dunlap
@ 2009-01-13 3:26 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2009-01-13 3:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, scsi, James Bottomley,
Andrew Morton
>>>>> "Randy" == Randy Dunlap <randy.dunlap@oracle.com> writes:
Randy> From: Randy Dunlap <randy.dunlap@oracle.com> Fix scsi_debug build
Randy> error:
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-13 3:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090112154539.4857f533.sfr@canb.auug.org.au>
2009-01-12 18:50 ` [PATCH -next] libfc: needs CRC32 Randy Dunlap
2009-01-13 0:05 ` Love, Robert W
2009-01-12 18:53 ` [PATCH -next] scsi_debug: needs CRC_T10DIF Randy Dunlap
2009-01-13 3:26 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox