Re: [Open/iSCSI] Memory leak in repetitive --login/--logout with v2.0-870.1

[Mike Christie <michaelc@cs.wisc.edu>]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Mike Christie wrote:
> Nicholas A. Bellinger wrote:
> 
>> Ok, I still have my hands full with LIO v3.0 code atm, so I am not sure
>> how soon I could get to this..
>>
> 
> Don't worry about it. I can replicate it here.
> 

Crazy, I guess it is a leak we always had (at least back to 2.6.22 (did 
not look firther)), and no one noticed. Here is a patch. I will send it 
to James with some other patches I had.

Thanks for the report.

[-- Attachment #2: libiscsi-fix-pool-queue-leak.patch --]
[-- Type: text/plain, Size: 335 bytes --]

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 7225b6e..257c241 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1981,6 +1981,7 @@ void iscsi_pool_free(struct iscsi_pool *q)
 		kfree(q->pool[i]);
 	if (q->pool)
 		kfree(q->pool);
+	kfree(q->queue);
 }
 EXPORT_SYMBOL_GPL(iscsi_pool_free);