[PATCH] iscsi tcp: bidi capable

[PATCH] iscsi tcp: bidi capable

[Boaz Harrosh]

From: Pete Wyckoff <pw@padd.com>

Mark iscsi_tcp as being capable of bidirectional transfers.  The
bsg interface checks this bit before attempting any bidirectional
commands.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 drivers/scsi/iscsi_tcp.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index af092a8..9e2d4fb 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -806,6 +806,12 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
 	iscsi_host_free(shost);
 }
 
+static int iscsi_tcp_slave_alloc(struct scsi_device *sdev)
+{
+	set_bit(QUEUE_FLAG_BIDI, &sdev->request_queue->queue_flags);
+	return 0;
+}
+
 static int iscsi_sw_tcp_slave_configure(struct scsi_device *sdev)
 {
 	blk_queue_bounce_limit(sdev->request_queue, BLK_BOUNCE_ANY);
@@ -826,6 +832,7 @@ static struct scsi_host_template iscsi_sw_tcp_sht = {
 	.eh_device_reset_handler= iscsi_eh_device_reset,
 	.eh_target_reset_handler= iscsi_eh_target_reset,
 	.use_clustering         = DISABLE_CLUSTERING,
+	.slave_alloc            = iscsi_tcp_slave_alloc,
 	.slave_configure        = iscsi_sw_tcp_slave_configure,
 	.proc_name		= "iscsi_tcp",
 	.this_id		= -1,
-- 
1.6.0.1

Re: [PATCH] iscsi tcp: bidi capable

[Boaz Harrosh]

Boaz Harrosh wrote:
> From: Pete Wyckoff <pw@padd.com>
> 
> Mark iscsi_tcp as being capable of bidirectional transfers.  The
> bsg interface checks this bit before attempting any bidirectional
> commands.
> 
> Signed-off-by: Pete Wyckoff <pw@padd.com>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
<snip>

Mike hi, whatever happened with this patch?

It is over scsi-misc but I think it should be good for iscsi tree. (Sorry)
Since open-osd is apparently only going into next Kernel, sigh.
Then this is fine for the next Kernel as well.

(I was advertising BIDI kernels since 2.6.26, well I guess not
 from bsg+iscsi)

Thanks
Boaz

Re: [PATCH] iscsi tcp: bidi capable

[Mike Christie]

Boaz Harrosh wrote:
> Boaz Harrosh wrote:
>> From: Pete Wyckoff <pw@padd.com>
>>
>> Mark iscsi_tcp as being capable of bidirectional transfers.  The
>> bsg interface checks this bit before attempting any bidirectional
>> commands.
>>
>> Signed-off-by: Pete Wyckoff <pw@padd.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
> <snip>
> 
> Mike hi, whatever happened with this patch?
> 

I never saw it before. I must have missed it. I will queue it for the 
next feature window.

Re: [PATCH] iscsi tcp: bidi capable

[Mike Christie]

Boaz Harrosh wrote:
> From: Pete Wyckoff <pw-VNBDo6LsbKA@public.gmane.org>
> 
> Mark iscsi_tcp as being capable of bidirectional transfers.  The
> bsg interface checks this bit before attempting any bidirectional
> commands.
> 
> Signed-off-by: Pete Wyckoff <pw-VNBDo6LsbKA@public.gmane.org>
> Signed-off-by: Boaz Harrosh <bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/scsi/iscsi_tcp.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index af092a8..9e2d4fb 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -806,6 +806,12 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
>  	iscsi_host_free(shost);
>  }
>  
> +static int iscsi_tcp_slave_alloc(struct scsi_device *sdev)
> +{

I merged this for 2.6.30 with a small change where this is renamed 
iscsi_sw_tcp_slave_alloc to fit the naming of functions in that file.

Thanks.

Re: [PATCH] iscsi tcp: bidi capable

[Boaz Harrosh]

Mike Christie wrote:
> Boaz Harrosh wrote:
>> From: Pete Wyckoff <pw@padd.com>
>>
>> Mark iscsi_tcp as being capable of bidirectional transfers.  The
>> bsg interface checks this bit before attempting any bidirectional
>> commands.
>>
>> Signed-off-by: Pete Wyckoff <pw@padd.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>>  drivers/scsi/iscsi_tcp.c |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
>> index af092a8..9e2d4fb 100644
>> --- a/drivers/scsi/iscsi_tcp.c
>> +++ b/drivers/scsi/iscsi_tcp.c
>> @@ -806,6 +806,12 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
>>  	iscsi_host_free(shost);
>>  }
>>  
>> +static int iscsi_tcp_slave_alloc(struct scsi_device *sdev)
>> +{
> 
> I merged this for 2.6.30 with a small change where this is renamed 
> iscsi_sw_tcp_slave_alloc to fit the naming of functions in that file.
> 

Sure, thanks, sorry. It's Pete's patch and I failed to adapt it to
latest changes.

> Thanks.
> 

Thanks
Boaz