From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: [PATCH] bsg: Error print if device is not bidi capable when refusing a bidi command Date: Tue, 20 Jan 2009 16:13:20 +0200 Message-ID: <4975DC00.2090005@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-ca.panasas.com ([66.104.249.162]:31235 "EHLO laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761041AbZATONX (ORCPT ); Tue, 20 Jan 2009 09:13:23 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori , Jens Axboe Cc: linux-scsi , open-osd mailing-list If a bidi command was issued to a request_queue not mark as QUEUE_FLAG_BIDI. Issue an error report. This is a misconfiguration an administrator would like to know about, which is otherwise hard to detect. Signed-off-by: Boaz Harrosh --- block/bsg.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 44a2a0f..977547a 100644 --- a/block/bsg.c +++ b/block/bsg.c @@ -270,6 +270,8 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm, if (rw == WRITE && hdr->din_xfer_len) { if (!test_bit(QUEUE_FLAG_BIDI, &q->queue_flags)) { + printk(KERN_ERR "bsg: Attempt to send a bidi command " + "to a none bidi device\n"); ret = -EOPNOTSUPP; goto out; } -- 1.6.0.1