From: Boaz Harrosh <bharrosh@panasas.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi <linux-scsi@vger.kernel.org>,
open-osd mailing-list <osd-dev@open-osd.org>
Subject: Re: [PATCH] bsg: Error print if device is not bidi capable when refusing a bidi command
Date: Tue, 20 Jan 2009 16:41:13 +0200 [thread overview]
Message-ID: <4975E289.1050407@panasas.com> (raw)
In-Reply-To: <20090120141517.GM30821@kernel.dk>
Jens Axboe wrote:
> On Tue, Jan 20 2009, Boaz Harrosh wrote:
>> If a bidi command was issued to a request_queue not mark as
>> QUEUE_FLAG_BIDI. Issue an error report. This is a misconfiguration
>> an administrator would like to know about, which is otherwise
>> hard to detect.
>
> At the very least, put rate limit on that printk.
>
Thanks, good catch it could be a DOS other wise. I did not know
of this facility. Please check if done right?
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>> block/bsg.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
Boaz
prev parent reply other threads:[~2009-01-20 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 14:13 [PATCH] bsg: Error print if device is not bidi capable when refusing a bidi command Boaz Harrosh
2009-01-20 14:15 ` Jens Axboe
2009-01-20 14:38 ` [PATCH ver2 printk_ratelimit] " Boaz Harrosh
2009-01-20 14:46 ` Jens Axboe
2009-01-20 15:01 ` Boaz Harrosh
2009-01-20 15:31 ` Boaz Harrosh
2009-01-21 7:53 ` Jens Axboe
2009-01-20 23:10 ` FUJITA Tomonori
2009-01-20 14:41 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975E289.1050407@panasas.com \
--to=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox