[PATCH 1/5] stex: Fix for potential invalid response

[PATCH 1/5] stex: Fix for potential invalid response

[Ed Lin - PTU]

The interrupt routine is good for normal cases. However, if the firmware
is abnormal and returns an invalid response, the driver may reuse a
ccb structure which has already been handled. This may cause problem.
Fix this by setting the req member to NULL. Next time we know the
response is invalid and handle accordingly if req is NULL.

Signed-off-by: Ed Lin <ed.lin@promise.com>
---

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index a3a18ad..6129db4 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32
doorbell)
 				stex_copy_data(ccb, resp, size);
 		}
 
+		ccb->req = NULL;
 		ccb->srb_status = resp->srb_status;
 		ccb->scsi_status = resp->scsi_status;
 

Re: [PATCH 1/5] stex: Fix for potential invalid response

[Jeff Garzik]

Ed Lin - PTU wrote:
> The interrupt routine is good for normal cases. However, if the firmware
> is abnormal and returns an invalid response, the driver may reuse a
> ccb structure which has already been handled. This may cause problem.
> Fix this by setting the req member to NULL. Next time we know the
> response is invalid and handle accordingly if req is NULL.
> 
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
> 
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index a3a18ad..6129db4 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32
> doorbell)
>  				stex_copy_data(ccb, resp, size);
>  		}
>  
> +		ccb->req = NULL;
>  		ccb->srb_status = resp->srb_status;
>  		ccb->scsi_status = resp->scsi_status;

ACK patches 1-5

Re: [PATCH 1/5] stex: Fix for potential invalid response

[James Bottomley]

On Mon, 2009-01-26 at 02:40 -0800, Ed Lin - PTU wrote:
> The interrupt routine is good for normal cases. However, if the firmware
> is abnormal and returns an invalid response, the driver may reuse a
> ccb structure which has already been handled. This may cause problem.
> Fix this by setting the req member to NULL. Next time we know the
> response is invalid and handle accordingly if req is NULL.
> 
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
> 
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index a3a18ad..6129db4 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32
> doorbell)

The patches generally look fine.  Unfortunately your email tool has
broken the line ends of most of them (like the above) which makes it
almost impossible to apply them.  Could you resend with this fixed up?

Thanks,

James

RE: [PATCH 1/5] stex: Fix for potential invalid response

[Ed Lin - PTU]

>-----Original Message-----
>From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
>Sent: 2009年1月26日 11:17
>To: Ed Lin - PTU
>Cc: linux-scsi@vger.kernel.org; Promise_Linux
>Subject: Re: [PATCH 1/5] stex: Fix for potential invalid response
>
>
>On Mon, 2009-01-26 at 02:40 -0800, Ed Lin - PTU wrote:
>> The interrupt routine is good for normal cases. However, if 
>the firmware
>> is abnormal and returns an invalid response, the driver may reuse a
>> ccb structure which has already been handled. This may cause problem.
>> Fix this by setting the req member to NULL. Next time we know the
>> response is invalid and handle accordingly if req is NULL.
>> 
>> Signed-off-by: Ed Lin <ed.lin@promise.com>
>> ---
>> 
>> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
>> index a3a18ad..6129db4 100644
>> --- a/drivers/scsi/stex.c
>> +++ b/drivers/scsi/stex.c
>> @@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32
>> doorbell)
>
>The patches generally look fine.  Unfortunately your email tool has
>broken the line ends of most of them (like the above) which makes it
>almost impossible to apply them.  Could you resend with this fixed up?
>

Sure, I will do it shortly. Please let me know if it's still broken.
Sorry for the inconvenience.