From: Douglas Gilbert <dgilbert@interlog.com>
To: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Cc: Jens Axboe <jens.axboe@oracle.com>, linux-scsi@vger.kernel.org
Subject: Re: [Patch] sg: fix device number in blktrace data
Date: Fri, 30 Jan 2009 11:24:32 -0500 [thread overview]
Message-ID: <498329C0.5010704@interlog.com> (raw)
In-Reply-To: <1233326783.929.6.camel@kitka.ibm.com>
Martin Peschke wrote:
> Hi,
>
> we have run into an issue with blktrace being started for sg devices.
> Please apply.
>
> Thanks,
> Martin
>
>
>
> From: Martin Peschke <mpeschke@linux.vnet.ibm.com>
>
> The device number denoting a generic SCSI devices (sg) in a blktrace
> trace is broken; major and minor are always 0. It looks like
> sdp->device->sdev_gendev.devt is not initialized properly.
> The fix below uses other data to make up a valid device number,
> similar to the way an sg device number is generated for sysfs output.
>
> Reported-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
> Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
prev parent reply other threads:[~2009-01-30 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 14:46 [Patch] sg: fix device number in blktrace data Martin Peschke
2009-01-30 16:24 ` Douglas Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498329C0.5010704@interlog.com \
--to=dgilbert@interlog.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mpeschke@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox