From: Roel Kluin <roel.kluin@gmail.com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] ses: code_set == 1 is tested twice
Date: Tue, 17 Feb 2009 16:59:24 +0100 [thread overview]
Message-ID: <499ADEDC.108@gmail.com> (raw)
Maybe double check whether something else is missing instead?
Otherwise feel free to ignore.
--------------------------->8-------------8<------------------------------
code_set == 1 is tested twice.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index e946e05..a3da4ce 100644
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -393,7 +393,7 @@ static void ses_match_to_enclosure(struct enclosure_device *edev,
u8 type = desc[1] & 0x0f;
u8 len = desc[3];
- if (piv && code_set == 1 && assoc == 1 && code_set == 1
+ if (piv && code_set == 1 && assoc == 1
&& proto == SCSI_PROTOCOL_SAS && type == 3 && len == 8)
efd.addr = (u64)desc[4] << 56 |
(u64)desc[5] << 48 |
reply other threads:[~2009-02-17 15:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499ADEDC.108@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox