From: Mike Christie <michaelc@cs.wisc.edu>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] libiscsi: fix iscsi pool error path
Date: Thu, 19 Feb 2009 11:26:19 -0600 [thread overview]
Message-ID: <499D963B.7050106@cs.wisc.edu> (raw)
In-Reply-To: <200902182035.23939.jdelvare@suse.de>
Jean Delvare wrote:
> Memory freeing in iscsi_pool_free() looks wrong to me. Either q->pool
> can be NULL and this should be tested before dereferencing it, or it
> can't be NULL and it shouldn't be tested at all. As far as I can see,
> the only case where q->pool is NULL is on early error in
> iscsi_pool_init(). One possible way to fix the bug is thus to not
> call iscsi_pool_free() in this case (nothing needs to be freed anyway)
> and then we can get rid of the q->pool check.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Acked-by: Mike Christie <michaelc@cs.wisc.edu>
James,
If you are scooping up late fixes for 2.6.29-rc, then please take this
if it qualifies. It is not a regression, but a simple bug fix that can
be hit in situations where there is small amounts of memory (for some
reason common in virtual machine setups a lot).
prev parent reply other threads:[~2009-02-19 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 19:35 [PATCH] [SCSI] libiscsi: fix iscsi pool error path Jean Delvare
2009-02-19 17:26 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499D963B.7050106@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jdelvare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox