From: Mike Christie <michaelc@cs.wisc.edu>
To: Abhijeet Joglekar <abjoglek@cisco.com>
Cc: james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, jeykholt@cisco.com
Subject: Re: [RFC][PATCH 3/6] fnic: Add support for Fibre Channel Services through libFC
Date: Thu, 12 Mar 2009 15:36:04 -0500 [thread overview]
Message-ID: <49B97234.5040801@cs.wisc.edu> (raw)
In-Reply-To: <20090228023209.12158.30405.stgit@feynman.nuovasystems.com>
Abhijeet Joglekar wrote:
> +
> +static ssize_t fnic_show_drv_version(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + return snprintf(buf, PAGE_SIZE, "%s\n", DRV_VERSION);
> +}
I think in the past we were supposed to just export this with the
MODULE_VERSION() function (you can then see it /sys/module/fnic/version).
I saw other FC drivers put it on the host now though, so maybe it is ok now.
next prev parent reply other threads:[~2009-03-12 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 2:31 [PATCH 0/6] FCoE HBA Driver (fnic) for 2.6.30 feature window Abhijeet Joglekar
2009-02-28 2:31 ` [RFC][PATCH 1/6] fnic: add main file with module infrastructure, fnic structure, Makefile Abhijeet Joglekar
2009-03-12 20:13 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 2/6] fnic: add SCSI FCP handling Abhijeet Joglekar
2009-03-12 20:27 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 3/6] fnic: Add support for Fibre Channel Services through libFC Abhijeet Joglekar
2009-03-12 20:36 ` Mike Christie [this message]
2009-02-28 2:32 ` [RFC][PATCH 4/6] fnic: adds resource allocation, interupt interfaces Abhijeet Joglekar
2009-02-28 2:32 ` [RFC][PATCH 5/6] fnic: add descriptor right, buffers, device interface Abhijeet Joglekar
2009-03-12 20:43 ` Mike Christie
2009-03-12 22:10 ` Abhijeet Arvind Joglekar (abjoglek)
2009-03-17 16:41 ` Mike Christie
2009-02-28 2:32 ` [RFC][PATCH 6/6] fnic: Patch MAINTAINERS, scsi Makefile, scsi Kconfig Abhijeet Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B97234.5040801@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=abjoglek@cisco.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox