From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Jones Subject: Re: [PATCH 1/3] scsi_dh: Add modalias support for SCSI targets Date: Fri, 20 Mar 2009 14:24:09 -0400 Message-ID: <49C3DF49.8050408@redhat.com> References: <20090318013615.26548.36303.sendpatchset@chandra-ubuntu> <20090318013621.26548.10529.sendpatchset@chandra-ubuntu> <1237403902.14147.25.camel@chandra-ubuntu> <1237488880.26341.15.camel@chandra-ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53975 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbZCTSYi (ORCPT ); Fri, 20 Mar 2009 14:24:38 -0400 In-Reply-To: <1237488880.26341.15.camel@chandra-ubuntu> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: sekharan@linux.vnet.ibm.com Cc: Kay Sievers , linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu, James.Bottomley@hansenpartnership.com On 03/19/2009 02:54 PM, Chandra Seetharaman wrote: > On Wed, 2009-03-18 at 12:18 -0700, Chandra Seetharaman wrote: >> On Wed, 2009-03-18 at 19:30 +0100, Kay Sievers wrote: >>> On Wed, Mar 18, 2009 at 02:36, Chandra Seetharaman wrote: >>>> From: Peter Jones >>>> >>>> This patch allows the use of modaliases on scsi targets to correctly >>>> load scsi device handler modules when the devices are found. >>>> +++ linux-2.6.28/include/linux/mod_devicetable.h >>>> @@ -454,4 +454,10 @@ struct dmi_system_id { >>>> >>>> #define DMI_MATCH(a, b) { a, b } >>>> >>>> +struct scsi_dh_device_id { >>>> + unsigned char type; >>>> + char vendor[9]; >>>> + char model[17]; >>>> +}; >>> Doesn't the static array waste space, when used for the long lists of >>> entries stuffed in arrays of this structure? It will carry a lot of \0 >>> chars, and identical strings can not be de-duplicated by the compiler, >>> unlike when pointers are used? >>> >> I had some problems when we used the pointers instead of arrays. Don't >> recall it now. >> >> Will retry and report. > > Hi Kay, > > I tried it and realized modpost is what is giving the problem. > > When the array for vendor and model is changed to pointers, modpost (at > the end of make modules) dies with a segmentation fault. > > Peter, Any details that you can provide ? In this case, the tail wags the dog -- it's a string instead of a pointer basicallly so that the new bits in file2alias.c can look like the other parts of that same file. It's sortof inconvenient for them to be pointers in there... -- Peter If the facts don't fit the theory, change the facts. -- Einstein