public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sg: return EFAULT for an invalid user address
Date: Fri, 03 Apr 2009 13:25:18 -0400	[thread overview]
Message-ID: <49D6467E.2050604@interlog.com> (raw)
In-Reply-To: <20090404003430M.fujita.tomonori@lab.ntt.co.jp>

FUJITA Tomonori wrote:
> Hopefully, This is the last fix for the fallout of the block layer
> conversion...
> 
> This should be go into 2.6.28.y and 2.6.29.y with the other sg fixes.
> 
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] sg: return EFAULT for an invalid user address
> 
> blk_rq_unmap_user() returns EFAULT if a program passes an invalid
> address to kernel (the kernel fails to copy data to user space). sg
> needs to pass the returned value to user space instead of ignoring
> it. Before the block layer conversion, sg returns EFAULT
> properly. This restores the old behavior.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>

      reply	other threads:[~2009-04-03 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 15:35 [PATCH] sg: return EFAULT for an invalid user address FUJITA Tomonori
2009-04-03 17:25 ` Douglas Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D6467E.2050604@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox