Re: [PATCH 1/4] libosd: potential ERR_PTR dereference in osd_initiator.c

[Boaz Harrosh <bharrosh@panasas.com>]

Sorry I forgot to put:

From: Dan Carpenter <error27@gmail.com>
On 04/19/2009 07:07 PM, Boaz Harrosh wrote:
> bio_map_kern() returns an ERR_PTR() not NULL.
> 
> Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
>  drivers/scsi/osd/osd_initiator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
> index 2a5f077..76de889 100644
> --- a/drivers/scsi/osd/osd_initiator.c
> +++ b/drivers/scsi/osd/osd_initiator.c
> @@ -612,9 +612,9 @@ static int _osd_req_list_objects(struct osd_request *or,
>  
>  	WARN_ON(or->in.bio);
>  	bio = bio_map_kern(q, list, len, or->alloc_flags);
> -	if (!bio) {
> +	if (IS_ERR(bio)) {
>  		OSD_ERR("!!! Failed to allocate list_objects BIO\n");
> -		return -ENOMEM;
> +		return PTR_ERR(bio);
>  	}
>  
>  	bio->bi_rw &= ~(1 << BIO_RW);