Re: [PATCH] ipr: ipr_remove() marked __devexit

[Brian King <brking@linux.vnet.ibm.com>]

James Bottomley wrote:
> On Mon, 2009-04-20 at 10:56 -0300, Kleber S. Souza wrote:
>> On Fri, 2009-04-17 at 22:05 -0400, James Bottomley wrote:
>>> On Fri, 2009-04-17 at 16:08 -0300, Kleber S. Souza wrote:
>>>> Hi,
>>>>
>>>> Any comments on this patch? 
>>>>
>>>> It was acked by Brian King, do I need to do anything else to get it
>>>> accepted?
>>> No ... looks OK to me:
>>>
>>>> Thanks,
>>>> Kleber
>>>>
>>>> On Mon, 2009-03-23 at 17:12 -0300, Kleber Sacilotto de Souza wrote:
>>>>> Marking the ipr clean up function ipr_remove() as __devexit and using
>>>>> __devexit_p() macro in its address reference.
>>>>>
>>>>>
>>>>> Signed-off-by: Kleber Sacilotto de Souza <kleber@linux.vnet.ibm.com>
>>>>> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
>>> Just explain this signoff?  signed-off-by is supposed to document the
>>> hands the patch has passed through ... it's not clear what Breno Leitao
>>> has to do with the transmission of this patch.
>>>
>> Breno Leitão pointed out to me that this change needed to be made based
>> on the kernel documentation <Documentation/PCI/pci.txt>. I wrote the
>> patch, got the ack from Brian King and sent it to the list.
> 
> So that should be Reported-by: not Signed-off-by for Breno.
> 
> There's no actual ack from Brian King on this email.

Acked by: Brian King <brking@linux.vnet.ibm.com>

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html