* [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space()
@ 2009-04-20 19:23 Kleber S. Souza
2009-04-20 22:11 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Kleber S. Souza @ 2009-04-20 19:23 UTC (permalink / raw)
To: linux-scsi@vger.kernel.org
The key functions of the ipr driver call two macros defined in 'ipr.h',
'ENTER' and 'LEAVE', upon entering and leaving the functions, in order
to print debug messages when the driver is loaded with the option
'debug=1'. Before returning, ipr_reset_restore_cfg_space() calls 'ENTER'
where it should call 'LEAVE'. This patch calls the right macro before
returning from the function.
Signed-off-by: Kleber S. Souza <klebers@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index c09d775..23f4af2 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6522,7 +6522,7 @@ static int ipr_reset_restore_cfg_space(struct
ipr_cmnd *ipr_cmd)
}
}
- ENTER;
+ LEAVE;
return IPR_RC_JOB_CONTINUE;
}
--
--
Kleber S. Souza
IBM Linux Technology Center
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space()
2009-04-20 19:23 [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space() Kleber S. Souza
@ 2009-04-20 22:11 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2009-04-20 22:11 UTC (permalink / raw)
To: Kleber S. Souza; +Cc: linux-scsi@vger.kernel.org
Acked by: Brian King <brking@linux.vnet.ibm.com>
Kleber S. Souza wrote:
> The key functions of the ipr driver call two macros defined in 'ipr.h',
> 'ENTER' and 'LEAVE', upon entering and leaving the functions, in order
> to print debug messages when the driver is loaded with the option
> 'debug=1'. Before returning, ipr_reset_restore_cfg_space() calls 'ENTER'
> where it should call 'LEAVE'. This patch calls the right macro before
> returning from the function.
>
>
>
> Signed-off-by: Kleber S. Souza <klebers@linux.vnet.ibm.com>
> ---
> drivers/scsi/ipr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index c09d775..23f4af2 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -6522,7 +6522,7 @@ static int ipr_reset_restore_cfg_space(struct
> ipr_cmnd *ipr_cmd)
> }
> }
>
> - ENTER;
> + LEAVE;
> return IPR_RC_JOB_CONTINUE;
> }
>
> --
>
>
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-20 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-20 19:23 [PATCH] ipr: fix debug macro call in ipr_reset_restore_cfg_space() Kleber S. Souza
2009-04-20 22:11 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).