Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Karen Higgins <karen.higgins@qlogic.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] qla4xxx: Driver Fault Recovery
Date: Mon, 27 Apr 2009 10:09:12 -0500	[thread overview]
Message-ID: <49F5CA98.8060708@cs.wisc.edu> (raw)
In-Reply-To: <DBF768B1A111084580554DADE800BF9D72EA041EFD@AVEXMB2.qlogic.org>

Karen Higgins wrote:
> Driver Fault Recovery
> 
> Fixed driver bug where adapter recovery did not complete if there were
> outstanding commands detected on that host adapter.
> 
> Signed-off-by: Karen Higgins <karen.higgins@qlogic.com>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c |   19 +++++++++----------
>  1 files changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index eb3a414..fcc65a5 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -904,18 +904,17 @@ static int qla4xxx_recover_adapter(struct scsi_qla_host *ha,
>      /* Flush any pending ddb changed AENs */
>      qla4xxx_process_aen(ha, FLUSH_DDB_CHANGED_AENS);
>  
> +    qla4xxx_flush_active_srbs(ha);
> +
>      /* Reset the firmware.    If successful, function
>       * returns with ISP interrupts enabled.
>       */
> -    if (status == QLA_SUCCESS) {
> -        DEBUG2(printk("scsi%ld: %s - Performing soft reset..\n",
> -                  ha->host_no, __func__));
> -        qla4xxx_flush_active_srbs(ha);
> -        if (ql4xxx_lock_drvr_wait(ha) == QLA_SUCCESS)
> -            status = qla4xxx_soft_reset(ha);
> -        else
> -            status = QLA_ERROR;
> -    }
> +    DEBUG2(printk("scsi%ld: %s - Performing soft reset..\n",
> +              ha->host_no, __func__));
> +    if (ql4xxx_lock_drvr_wait(ha) == QLA_SUCCESS)
> +        status = qla4xxx_soft_reset(ha);
> +    else
> +        status = QLA_ERROR;
>  
>      /* Flush any pending ddb changed AENs */
>      qla4xxx_process_aen(ha, FLUSH_DDB_CHANGED_AENS);
> @@ -1644,7 +1643,7 @@ static int qla4xxx_eh_host_reset(struct scsi_cmnd *cmd)
>      ha = (struct scsi_qla_host *) cmd->device->host->hostdata;
>  
>      dev_info(&ha->pdev->dev,
> -           "scsi(%ld:%d:%d:%d): ADAPTER RESET ISSUED.\n", ha->host_no,
> +           "scsi(%ld:%d:%d:%d): HOST RESET ISSUED.\n", ha->host_no,
>             cmd->device->channel, cmd->device->id, cmd->device->lun);
>  
>      if (qla4xxx_wait_for_hba_online(ha) != QLA_SUCCESS) {



My mailer is messing up the formatting so it looks like spaces instead 
of tabs are getting adedd. If that is my mailers fault then patch looks ok:

Reviewed-by Mike Christie <michaelc@cs.wisc.edu>

  reply	other threads:[~2009-04-27 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 16:24 [PATCH 2/2] qla4xxx: Driver Fault Recovery Karen Higgins
2009-04-27 15:09 ` Mike Christie [this message]
2009-04-27 15:13   ` Matthew Wilcox
2009-04-27 15:15     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F5CA98.8060708@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=karen.higgins@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox