From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH] set CONFIG_SCSI_MULTI_LUN by default and update help
Date: Sun, 03 May 2009 15:57:30 +0200 [thread overview]
Message-ID: <49FDA2CA.4040601@tremplin-utc.net> (raw)
Hello,
Here is a patch against 2.6.30-rc4, but probably material for 2.6.31,
which should avoid a couple of people to have the same problem as me.
Eric
==
I had to set CONFIG_SCSI_MULTI_LUN to y in order to get my SE W595
working when plugging it as a mass storage. Looking at SCSI option to
get a phone behaving correctly was convoluted to say the
least. There are quite a few other reports about USB card readers
needing this option as well.
This patch improves the help text to make the use of the option more
obvious and also defaults it to Y. I couldn't find any explicit reports
of devices not working because of multiple LUNs probing, but only
reports of people would had heard of such reports. In addition, every
mainstream distro have this option activated, so it should definitely
not be too dangerous.
Signed-off-by: Eric Piel <eric.piel@tremplin-utc.net>
---
drivers/scsi/Kconfig | 18 ++++++++----------
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 8ed2990..1aa1d7d 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -191,20 +191,18 @@ config SCSI_ENCLOSURE
it has an enclosure device. Selecting this option will just allow
certain enclosure conditions to be reported and is not required.
-comment "Some SCSI devices (e.g. CD jukebox) support multiple LUNs"
- depends on SCSI
-
config SCSI_MULTI_LUN
bool "Probe all LUNs on each SCSI device"
depends on SCSI
+ default y
help
- If you have a SCSI device that supports more than one LUN (Logical
- Unit Number), e.g. a CD jukebox, and only one LUN is detected, you
- can say Y here to force the SCSI driver to probe for multiple LUNs.
- A SCSI device with multiple LUNs acts logically like multiple SCSI
- devices. The vast majority of SCSI devices have only one LUN, and
- so most people can say N here. The max_luns boot/module parameter
- allows to override this setting.
+ Some devices support more than one LUN (Logical Unit Number) in order
+ to allow access to several media, e.g. CD jukebox, USB card reader,
+ mobile phone in mass storage mode. This option forces the kernel to
+ probe for all LUNs by default. This setting can be overriden by
+ max_luns boot/module parameter. You want to say Y here unless you
+ have one of those rare devices which reacts in an unexpected way when
+ probed for multiple LUNs.
config SCSI_CONSTANTS
bool "Verbose SCSI error reporting (kernel size +=12K)"
--
1.6.2.4
next reply other threads:[~2009-05-03 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 13:57 Éric Piel [this message]
2009-05-03 14:57 ` [PATCH] set CONFIG_SCSI_MULTI_LUN by default and update help James Bottomley
2009-05-03 15:08 ` Éric Piel
2009-05-03 15:17 ` James Bottomley
2009-05-03 15:11 ` Matthew Wilcox
2009-05-03 15:21 ` James Bottomley
2009-05-03 15:24 ` Matthew Wilcox
2009-05-03 18:37 ` Alan Stern
2009-05-04 10:43 ` [PATCH] Update wording of CONFIG_SCSI_MULTI_LUN help Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FDA2CA.4040601@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox