From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: Arun Easi <arun.easi@cavium.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iSCSI-target: Use common error handling code in iscsi_decode_text_input()
Date: Mon, 6 Nov 2017 22:11:06 +0100 [thread overview]
Message-ID: <49e62625-8c1d-5bbe-2ddd-e25e117754db@users.sourceforge.net> (raw)
In-Reply-To: <20171106162549.5b2511db@alans-desktop>
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>
> Why not look at what the C compiler generates before making the code
> less readable ?
* Does the adjusted source code layout fit to information from the section
“7) Centralized exiting of functions” in the document “coding-style.rst”?
* Would you find a reduction of 16 bytes for the object code useful for
the affected function implementation?
Regards,
Markus
prev parent reply other threads:[~2017-11-06 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 21:33 [PATCH] iSCSI-target: Use common error handling code in iscsi_decode_text_input() SF Markus Elfring
2017-11-06 16:25 ` Alan Cox
2017-11-06 21:11 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e62625-8c1d-5bbe-2ddd-e25e117754db@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=arun.easi@cavium.com \
--cc=bart.vanassche@sandisk.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).