From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Ying Chu <jasonchu@marvell.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/4] mvsas: Set Hardware Bit for TMF
Date: Fri, 08 May 2009 16:07:58 -0400 [thread overview]
Message-ID: <4A04911E.6090409@garzik.org> (raw)
In-Reply-To: <1241797648.3327.55.camel@mulgrave.int.hansenpartnership.com>
James Bottomley wrote:
> On Fri, 2009-05-08 at 14:17 +0800, Ying Chu wrote:
>> - hdr->flags = cpu_to_le32(flags |
>> - (tei->n_elem << MCH_PRD_LEN_SHIFT) |
>> - (MCH_SSP_FR_CMD << MCH_SSP_FR_TYPE_SHIFT));
>> + if (is_tmf)
>> + flags |= (MCH_SSP_FR_TASK << MCH_SSP_FR_TYPE_SHIFT);
>> + hdr->flags = cpu_to_le32(flags | (tei->n_elem << MCH_PRD_LEN_SHIFT));
>
> If is_tmf isn't set, shouldn't we be setting the command frame
> indicator, like the old code was? (I know it's sort of irrelevant
> because MCH_SSP_FR_CMD is defined to be zero, so if you're just dumping
> the definition MCH_SSP_FR_CMD, that's fine too).
Yeah, it's largely a matter of taste.
But even if MCH_SSP_FR_CMD is never used, its definition should remain,
because the hardware documentation is not public.
Jeff
next prev parent reply other threads:[~2009-05-08 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 6:17 [PATCH 3/4] mvsas: Set Hardware Bit for TMF Ying Chu
2009-05-08 15:47 ` James Bottomley
2009-05-08 20:07 ` Jeff Garzik [this message]
2009-05-08 20:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A04911E.6090409@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jasonchu@marvell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox