[PATCH 1/5] mvsas: bug fix with setting task management frame type

[PATCH 1/5] mvsas: bug fix with setting task management frame type

[Andy Yan]

>From 5cd41873370e1e7df7404dad798ed8ad745c304b Mon Sep 17 00:00:00 2001
From: Andy Yan <ayan@marvell.com>
Date: Mon, 11 May 2009 20:01:55 +0800
Subject: [PATCH 1/5] mvsas: bug fix with setting task management frame type

Correct frame type setting according to parameter.

Signed-off-by: Ying Chu <jasonchu@marvell.com>
Signed-off-by: Andy Yan <ayan@marvell.com>
Signed-off-by: Ke Wei <kewei@marvell.com>
---
 drivers/scsi/mvsas/mv_sas.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index d79ac17..f709319 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -761,9 +761,11 @@ static int mvs_task_prep_ssp(struct mvs_info *mvi,
 		flags |= MCH_FBURST;
 		fburst = (1 << 7);
 	}
-	hdr->flags = cpu_to_le32(flags |
-				 (tei->n_elem << MCH_PRD_LEN_SHIFT) |
-				 (MCH_SSP_FR_CMD << MCH_SSP_FR_TYPE_SHIFT));
+	if (is_tmf)
+		flags |= (MCH_SSP_FR_TASK << MCH_SSP_FR_TYPE_SHIFT);
+	else
+		flags |= (MCH_SSP_FR_CMD << MCH_SSP_FR_TYPE_SHIFT);
+	hdr->flags = cpu_to_le32(flags | (tei->n_elem << MCH_PRD_LEN_SHIFT));
 	hdr->tags = cpu_to_le32(tag);
 	hdr->data_len = cpu_to_le32(task->total_xfer_len);
 
-- 
1.6.2.1

Re: [PATCH 1/5] mvsas: bug fix with setting task management frame type

[Jeff Garzik]

Andy Yan wrote:
>>From 5cd41873370e1e7df7404dad798ed8ad745c304b Mon Sep 17 00:00:00 2001
> From: Andy Yan <ayan@marvell.com>
> Date: Mon, 11 May 2009 20:01:55 +0800
> Subject: [PATCH 1/5] mvsas: bug fix with setting task management frame type
> 
> Correct frame type setting according to parameter.
> 
> Signed-off-by: Ying Chu <jasonchu@marvell.com>
> Signed-off-by: Andy Yan <ayan@marvell.com>
> Signed-off-by: Ke Wei <kewei@marvell.com>

Acked-by: Jeff Garzik <jgarzik@redhat.com>

Re: [PATCH 1/5] mvsas: bug fix with setting task management frame type

[Jeff Garzik]

Additional request:

When revising a patch, please indicate revision in the email subject 
line or email body.

For example:

1) Initial posting:

     Subject:
	[PATCH 5/5] mvsas: optimization of code

     Body:
	patch description
	patch content

2) First revision, removing void* casts:

     Subject:
	[PATCH 5/5 v2] mvsas: optimization of code

     Body:
	patch description
	---
	"v2: updated to remove void* casts"
	patch content

3) Second revision, making some other example change:

     Subject:
	[PATCH 5/5 v3] mvsas: optimization of code

     Body:
	patch description
	---
	"v3: description of third change..."
	"v2: updated to remove void* casts"
	patch content

James or others may have other suggestions, but this is the basic idea 
for revising patches.

This accomplishes two goals:

	a) Indicate email containing latest changes
	b) Describe changes from previous patch revision

Best regards,

	Jeff