From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
James Smart <James.Smart@Emulex.Com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
FUJITA Tomonori <tomof@acm.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <Jens.Axboe@oracle.com>
Subject: Re: [PATCH] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31 tree
Date: Tue, 19 May 2009 19:05:56 +0900 [thread overview]
Message-ID: <4A128484.4000708@kernel.org> (raw)
In-Reply-To: <4A12797B.2060901@panasas.com>
Hello, Boaz.
Just two minor things.
Boaz Harrosh wrote:
> /* we assume all request payload was transferred, residual == 0 */
> - req->data_len = 0;
> + req->resid_len = 0;
>
> if (rsp) {
> - rsp_len = blk_rq_bytes(rsp);
> - BUG_ON(job->reply->reply_payload_rcv_len > rsp_len);
Maybe convert it to WARN_ON() instead of removing?
> /* set reply (bidi) residual */
> - rsp->data_len = (rsp_len - job->reply->reply_payload_rcv_len);
> + rsp->resid_len = blk_rq_bytes(rsp) -
> + job->reply->reply_payload_rcv_len;
With the fix-fallouts patchset it, this can be
rsp->resid_len -= job->reply->reply_payload_rcv_len;
Other than above misc points,
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
next prev parent reply other threads:[~2009-05-19 10:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 9:18 [PATCH] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31 tree Boaz Harrosh
2009-05-19 10:05 ` Tejun Heo [this message]
2009-05-19 10:14 ` Boaz Harrosh
2009-05-19 12:54 ` [PATCH version 2] " Boaz Harrosh
2009-05-20 1:16 ` Stephen Rothwell
2009-05-20 8:11 ` Boaz Harrosh
2009-05-20 12:54 ` James Smart
2009-05-20 14:37 ` James Bottomley
2009-05-20 14:42 ` Stephen Rothwell
2009-05-20 14:47 ` James Bottomley
2009-05-20 16:20 ` James Bottomley
2009-05-20 16:39 ` Boaz Harrosh
2009-05-20 16:40 ` Boaz Harrosh
2009-05-20 16:43 ` James Bottomley
2009-05-20 16:59 ` Boaz Harrosh
2009-05-20 17:03 ` Boaz Harrosh
2009-05-20 17:11 ` James Bottomley
2009-05-20 14:45 ` Stephen Rothwell
2009-05-20 19:10 ` Jens Axboe
2009-05-20 4:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A128484.4000708@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=James.Smart@Emulex.Com \
--cc=Jens.Axboe@oracle.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).