* [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets
@ 2009-05-27 5:14 Jaswinder Singh Rajput
2009-05-27 14:27 ` Mike Christie
2009-06-20 7:59 ` [SCSI RESEND] " Jaswinder Singh Rajput
0 siblings, 2 replies; 4+ messages in thread
From: Jaswinder Singh Rajput @ 2009-05-27 5:14 UTC (permalink / raw)
To: James Bottomley, linux-scsi, Ingo Molnar, LKML,
Mike Christie <mic>
setting err as -EOVERFLOW for Too many iscsi targets.
Also fixes compiler warning for gcc < 4.3.3 :
CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
drivers/scsi/scsi_transport_iscsi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0947954..fdcda7f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
"Too many iscsi targets. Max "
"number of targets is %d.\n",
ISCSI_MAX_TARGET - 1);
+ err = -EOVERFLOW;
goto release_host;
}
}
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets
2009-05-27 5:14 [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets Jaswinder Singh Rajput
@ 2009-05-27 14:27 ` Mike Christie
2009-06-20 7:59 ` [SCSI RESEND] " Jaswinder Singh Rajput
1 sibling, 0 replies; 4+ messages in thread
From: Mike Christie @ 2009-05-27 14:27 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: James Bottomley, linux-scsi, Ingo Molnar, LKML
Jaswinder Singh Rajput wrote:
> setting err as -EOVERFLOW for Too many iscsi targets.
>
> Also fixes compiler warning for gcc < 4.3.3 :
>
> CC drivers/scsi/scsi_transport_iscsi.o
> drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
> drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index 0947954..fdcda7f 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
> "Too many iscsi targets. Max "
> "number of targets is %d.\n",
> ISCSI_MAX_TARGET - 1);
> + err = -EOVERFLOW;
> goto release_host;
> }
> }
Fine by me. Send it through whatever tree you guys want.
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [SCSI RESEND] scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets
2009-05-27 5:14 [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets Jaswinder Singh Rajput
2009-05-27 14:27 ` Mike Christie
@ 2009-06-20 7:59 ` Jaswinder Singh Rajput
2009-06-21 16:35 ` Mike Christie
1 sibling, 1 reply; 4+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 7:59 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, Ingo Molnar, LKML, Mike Christie
setting err as -EOVERFLOW for Too many iscsi targets.
Also fixes compiler warning for gcc 4.3.3 and gcc 4.4 :
CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
drivers/scsi/scsi_transport_iscsi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0947954..fdcda7f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
"Too many iscsi targets. Max "
"number of targets is %d.\n",
ISCSI_MAX_TARGET - 1);
+ err = -EOVERFLOW;
goto release_host;
}
}
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [SCSI RESEND] scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets
2009-06-20 7:59 ` [SCSI RESEND] " Jaswinder Singh Rajput
@ 2009-06-21 16:35 ` Mike Christie
0 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2009-06-21 16:35 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: James Bottomley, linux-scsi, Ingo Molnar, LKML
On 06/20/2009 02:59 AM, Jaswinder Singh Rajput wrote:
> setting err as -EOVERFLOW for Too many iscsi targets.
>
> Also fixes compiler warning for gcc 4.3.3 and gcc 4.4 :
>
> CC drivers/scsi/scsi_transport_iscsi.o
> drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
> drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
>
> Signed-off-by: Jaswinder Singh Rajput<jaswinderrajput@gmail.com>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index 0947954..fdcda7f 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
> "Too many iscsi targets. Max "
> "number of targets is %d.\n",
> ISCSI_MAX_TARGET - 1);
> + err = -EOVERFLOW;
> goto release_host;
> }
> }
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-21 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-27 5:14 [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOW for Too many iscsi targets Jaswinder Singh Rajput
2009-05-27 14:27 ` Mike Christie
2009-06-20 7:59 ` [SCSI RESEND] " Jaswinder Singh Rajput
2009-06-21 16:35 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox