From: Mike Christie <michaelc@cs.wisc.edu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
Karen Xie <kxie@chelsio.com>
Subject: Re: [SCSI] cxgb3i: Include net/dst.h for struct dst_cache
Date: Sun, 31 May 2009 21:25:06 -0500 [thread overview]
Message-ID: <4A233C02.7010505@cs.wisc.edu> (raw)
In-Reply-To: <20090530034004.GA20516@gondor.apana.org.au>
ccing cxgb3i driver maitainer.
Herbert Xu wrote:
> Hi:
>
> [SCSI] cxgb3i: Include net/dst.h for struct dst_cache
>
> This driver needs dst_cache->dev so it should include net/dst.h
> to ensure that it builds. While net/tcp.h probably includes it
> already, we shouldn't rely on that since there is no guarantee
> that this won't change in future.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> index 9212400..8b49731 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> +++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> @@ -13,6 +13,7 @@
>
> #include <linux/inet.h>
> #include <linux/crypto.h>
> +#include <net/dst.h>
> #include <net/tcp.h>
> #include <scsi/scsi_cmnd.h>
> #include <scsi/scsi_device.h>
>
Looks ok.
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2009-06-01 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 3:40 [SCSI] cxgb3i: Include net/dst.h for struct dst_cache Herbert Xu
2009-06-01 2:25 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A233C02.7010505@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=herbert@gondor.apana.org.au \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox