Re: [PATCH 4/6] SCSI: simplify target destruction

[Hannes Reinecke <hare@suse.de>]

Hi Alan,

Alan Stern wrote:
> This patch (as1249) adds an extra state, STARGET_NEW, to the SCSI
> target state model.  A target is in this state initially and changes
> over to STARGET_CREATED when the hostt->target_alloc() call has been
> made.
> 
> This simplifies target destruction.  There's no need for a separate
> scsi_target_destroy() function; everything can be handled within
> scsi_target_reap().  The error paths are more robust because now it's
> easy to verify that all the destructors are called along every
> pathway.
> 
Hmm. Is there a specific reason why we have to keep the ->reap_ref
counter around and cannot use the 'normal' driver core reference
counting for this?
Duplicating refcounting doesn't seem logical to me, given that
we already have a 'struct device' hanging about ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html