public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, rcjenn@linux.vnet.ibm.com
Subject: Re: [PATCH 2/4] ibmvscsi: Send adapter info before login
Date: Mon, 08 Jun 2009 15:19:57 -0500	[thread overview]
Message-ID: <4A2D726D.7060808@linux.vnet.ibm.com> (raw)
In-Reply-To: <1244491773.4079.595.camel@mulgrave.site>

James Bottomley wrote:
> On Wed, 2009-06-03 at 09:54 -0500, Brian King wrote:
>> The ibmvscsi driver currently sends the SRP Login before sending the Adapter
>> Info MAD, which can result in commands getting sent to the virtual adapter
>> before we are ready for them. This results in a slight window where the target
>> devices may not behave as expected. Change the order and close the window.
>>
>> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>> ---
>>
>>  drivers/scsi/ibmvscsi/ibmvscsi.c |  173 +++++++++++++++++++--------------------
>>  1 file changed, 85 insertions(+), 88 deletions(-)
> 
> This one just doesn't want to apply:
> 
> patching file drivers/scsi/ibmvscsi/ibmvscsi.c
> Hunk #4 FAILED at 961.
> Hunk #5 succeeded at 1279 (offset -3 lines).
> Hunk #6 succeeded at 1289 (offset -3 lines).
> 1 out of 6 hunks FAILED -- saving rejects to file
> drivers/scsi/ibmvscsi/ibmvscsi.c.rej
> 
> Could you check scsi-misc and see what's up?

I'll pull it down and take a look. This series should be applied
on top of 

http://marc.info/?l=linux-scsi&m=124388641607027&w=2

although I'm not sure that one liner could be causing all the trouble...

-Brian


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center



  reply	other threads:[~2009-06-08 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 14:54 [PATCH 2/4] ibmvscsi: Send adapter info before login Brian King
2009-06-08 20:09 ` James Bottomley
2009-06-08 20:19   ` Brian King [this message]
2009-06-08 20:23     ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D726D.7060808@linux.vnet.ibm.com \
    --to=brking@linux.vnet.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rcjenn@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox