From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Subject: Re: [PATCH 2/4] ibmvscsi: Send adapter info before login Date: Mon, 08 Jun 2009 15:23:07 -0500 Message-ID: <4A2D732B.2040004@linux.vnet.ibm.com> References: <200906031454.n53EsIr8011153@d01av04.pok.ibm.com> <1244491773.4079.595.camel@mulgrave.site> <4A2D726D.7060808@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e37.co.us.ibm.com ([32.97.110.158]:59062 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbZFHUXN (ORCPT ); Mon, 8 Jun 2009 16:23:13 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n58KMaHP005892 for ; Mon, 8 Jun 2009 14:22:36 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n58KN8iN074742 for ; Mon, 8 Jun 2009 14:23:08 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n58KN7b5016514 for ; Mon, 8 Jun 2009 14:23:08 -0600 In-Reply-To: <4A2D726D.7060808@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi@vger.kernel.org, rcjenn@linux.vnet.ibm.com Brian King wrote: > James Bottomley wrote: >> On Wed, 2009-06-03 at 09:54 -0500, Brian King wrote: >>> The ibmvscsi driver currently sends the SRP Login before sending the Adapter >>> Info MAD, which can result in commands getting sent to the virtual adapter >>> before we are ready for them. This results in a slight window where the target >>> devices may not behave as expected. Change the order and close the window. >>> >>> Signed-off-by: Brian King >>> --- >>> >>> drivers/scsi/ibmvscsi/ibmvscsi.c | 173 +++++++++++++++++++-------------------- >>> 1 file changed, 85 insertions(+), 88 deletions(-) >> This one just doesn't want to apply: >> >> patching file drivers/scsi/ibmvscsi/ibmvscsi.c >> Hunk #4 FAILED at 961. >> Hunk #5 succeeded at 1279 (offset -3 lines). >> Hunk #6 succeeded at 1289 (offset -3 lines). >> 1 out of 6 hunks FAILED -- saving rejects to file >> drivers/scsi/ibmvscsi/ibmvscsi.c.rej >> >> Could you check scsi-misc and see what's up? > > I'll pull it down and take a look. This series should be applied > on top of > > http://marc.info/?l=linux-scsi&m=124388641607027&w=2 > > although I'm not sure that one liner could be causing all the trouble... My guess is its this patch: http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=16b3858ec967f4d9817f6958cc7a0bf1222355f3 The same change was also included in patch 2 in this series. I'll rediff and resend... Thanks, Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center