Re: linux-next: Tree for June 16 (osd)

Re: linux-next: Tree for June 16 (osd)

[Randy Dunlap]

Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20090615:


When
CONFIG_BLK_DEV_OSD=y
CONFIG_SCSI_OSD_INITIATOR=y
# CONFIG_SCSI_OSD_ULD is not set

build fails with

drivers/built-in.o: In function `class_osdblk_remove':
osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
drivers/built-in.o: In function `class_osdblk_add':
osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

[PATCH -next] bnx2i/cnic: more kconfig dependencies

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

BNX2I selects CNIC, CNIC selects UIO.
It looks like BNX2I also needs to select UIO.

BTW, CNIC is under NETDEV_1000, which is not enabled.
I don't see any need to enable (select) it in this case,
but I could be wrong(?).  Should BNX2I also select NETDEV_1000?

cnic.c:(.text+0x17990b): undefined reference to `uio_event_notify'
cnic.c:(.text+0x17a197): undefined reference to `uio_unregister_device'
cnic.c:(.text+0x17c618): undefined reference to `__uio_register_device'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/bnx2i/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20090616.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20090616/drivers/scsi/bnx2i/Kconfig
@@ -2,6 +2,7 @@ config SCSI_BNX2_ISCSI
 	tristate "Broadcom NetXtreme II iSCSI support"
 	select SCSI_ISCSI_ATTRS
 	select CNIC
+	select UIO
 	depends on PCI
 	---help---
 	This driver supports iSCSI offload for the Broadcom NetXtreme II


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

Re: [PATCH -next] bnx2i/cnic: more kconfig dependencies

[Michael Chan]

On Tue, 2009-06-16 at 10:25 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> BNX2I selects CNIC, CNIC selects UIO.
> It looks like BNX2I also needs to select UIO.
> 

Yeah, it looks like if A selects B and B selects C, A does not
automatically select C, so we need to add it explicitly.

> BTW, CNIC is under NETDEV_1000, which is not enabled.
> I don't see any need to enable (select) it in this case,
> but I could be wrong(?).  Should BNX2I also select NETDEV_1000?

No that's not needed assuming we stay with using symbol_get() to resolve
a bnx2 driver symbol for now.

Thanks.

Acked-by: Michael Chan <mchan@broadcom.com>

> 
> cnic.c:(.text+0x17990b): undefined reference to `uio_event_notify'
> cnic.c:(.text+0x17a197): undefined reference to `uio_unregister_device'
> cnic.c:(.text+0x17c618): undefined reference to `__uio_register_device'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/scsi/bnx2i/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20090616.orig/drivers/scsi/bnx2i/Kconfig
> +++ linux-next-20090616/drivers/scsi/bnx2i/Kconfig
> @@ -2,6 +2,7 @@ config SCSI_BNX2_ISCSI
>  	tristate "Broadcom NetXtreme II iSCSI support"
>  	select SCSI_ISCSI_ATTRS
>  	select CNIC
> +	select UIO
>  	depends on PCI
>  	---help---
>  	This driver supports iSCSI offload for the Broadcom NetXtreme II
> 
> 

Re: linux-next: Tree for June 16 (osd)

[Boaz Harrosh]

On 06/16/2009 07:46 PM, Randy Dunlap wrote:
> Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20090615:
> 
> 
> When
> CONFIG_BLK_DEV_OSD=y
> CONFIG_SCSI_OSD_INITIATOR=y
> # CONFIG_SCSI_OSD_ULD is not set
> 
> build fails with
> 
> drivers/built-in.o: In function `class_osdblk_remove':
> osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
> drivers/built-in.o: In function `class_osdblk_add':
> osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
> osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'
> 
> 

Thanks, osdblk has the wrong dependency, I will fix it.

Boaz

Re: linux-next: Tree for June 16 (osd)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi Boaz,

On Wed, 17 Jun 2009 15:45:18 +0300 Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> Thanks, osdblk has the wrong dependency, I will fix it.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

[PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD

[Boaz Harrosh]

I will be squashing the below patch into the osdblk patch and will
rebase the "linux-next" branch. (No one is dependent on this branch
so there is no reason not too)

---
Stephen Rothwell wrote:
When
CONFIG_BLK_DEV_OSD=y
CONFIG_SCSI_OSD_INITIATOR=y
\# CONFIG_SCSI_OSD_ULD is not set

build fails with:
drivers/built-in.o: In function `class_osdblk_remove':
osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
drivers/built-in.o: In function `class_osdblk_add':
osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'

Fix by setting the proper dependency for this driver

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 drivers/block/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 2f55a4b..1d886e0 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -300,7 +300,7 @@ config BLK_DEV_NBD
 
 config BLK_DEV_OSD
 	tristate "OSD object-as-blkdev support"
-	depends on SCSI_OSD_INITIATOR
+	depends on SCSI_OSD_ULD
 	---help---
 	  Saying Y or M here will allow the exporting of a single SCSI
 	  OSD (object-based storage) object as a Linux block device.
-- 
1.6.2.1

Re: [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi Boaz,

On Wed, 17 Jun 2009 16:36:28 +0300 Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> Stephen Rothwell wrote:
> When
> CONFIG_BLK_DEV_OSD=y
> CONFIG_SCSI_OSD_INITIATOR=y
> \# CONFIG_SCSI_OSD_ULD is not set

Actually it was Randy Dunlap.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD

[Randy Dunlap]

Boaz Harrosh wrote:
> I will be squashing the below patch into the osdblk patch and will
> rebase the "linux-next" branch. (No one is dependent on this branch
> so there is no reason not too)
> 
> ---
> Stephen Rothwell wrote:
> When
> CONFIG_BLK_DEV_OSD=y
> CONFIG_SCSI_OSD_INITIATOR=y
> \# CONFIG_SCSI_OSD_ULD is not set
> 
> build fails with:
> drivers/built-in.o: In function `class_osdblk_remove':
> osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
> drivers/built-in.o: In function `class_osdblk_add':
> osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
> osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'
> 
> Fix by setting the proper dependency for this driver
> 
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
>  drivers/block/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 2f55a4b..1d886e0 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -300,7 +300,7 @@ config BLK_DEV_NBD
>  
>  config BLK_DEV_OSD
>  	tristate "OSD object-as-blkdev support"
> -	depends on SCSI_OSD_INITIATOR
> +	depends on SCSI_OSD_ULD
>  	---help---
>  	  Saying Y or M here will allow the exporting of a single SCSI
>  	  OSD (object-based storage) object as a Linux block device.


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/