linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian King <brking@linux.vnet.ibm.com>
To: Wayne Boyer <wayneb@linux.vnet.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] ipr: differentiate pci-x and pci-e based adapters
Date: Wed, 17 Jun 2009 12:19:06 -0500	[thread overview]
Message-ID: <4A39258A.1060508@linux.vnet.ibm.com> (raw)
In-Reply-To: <4A392007.8020407@linux.vnet.ibm.com>

Acked-by: Brian King <brking@linux.vnet.ibm.com>

Wayne Boyer wrote:
> Brian King wrote:
>> Wayne Boyer wrote:
>>> @@ -7539,7 +7539,8 @@
>>>  	ata_host_init(&ioa_cfg->ata_host, &pdev->dev,
>>>  		      sata_port_info.flags, &ipr_sata_ops);
>>>
>>> -	ioa_cfg->chip_cfg = ipr_get_chip_cfg(dev_id);
>>> +	ioa_cfg->ipr_chip = ipr_get_chip_info(dev_id);
>>> +	ioa_cfg->chip_cfg = ioa_cfg->ipr_chip->cfg;
>> If ipr_get_chip_info returns NULL you will oops here.
>>
> 
> Updated patch below.
> 


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center



      reply	other threads:[~2009-06-17 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090616220853.799518360@linux.vnet.ibm.com>
2009-06-16 22:13 ` [PATCH 1/2] ipr: add test for MSI interrupt support Wayne Boyer
2009-06-17 15:39   ` Brian King
2009-06-16 22:13 ` [PATCH 2/2] ipr: differentiate pci-x and pci-e based adapters Wayne Boyer
2009-06-17 15:41   ` Brian King
2009-06-17 16:55     ` Wayne Boyer
2009-06-17 17:19       ` Brian King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A39258A.1060508@linux.vnet.ibm.com \
    --to=brking@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wayneb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).