* [PATCH -next] bnx2i/cnic: kconfig interactions
[not found] <20090618145949.d933719a.sfr@canb.auug.org.au>
@ 2009-06-18 16:55 ` Randy Dunlap
2009-06-18 18:39 ` Michael Chan
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2009-06-18 16:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Sam Ravnborg, Anil Veerabhadrappa, Michael Chan,
scsi, James Bottomley
From: Randy Dunlap <randy.dunlap@oracle.com>
NETDEVICES + NETDEV_1000 need to be enabled so that kconfig will check
those branches for selects and enforce "select UIO" under CNIC.
Otherwise the build fails with:
ERROR: "uio_unregister_device" [drivers/net/cnic.ko] undefined!
ERROR: "uio_event_notify" [drivers/net/cnic.ko] undefined!
ERROR: "__uio_register_device" [drivers/net/cnic.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>
---
drivers/scsi/bnx2i/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20090618.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20090618/drivers/scsi/bnx2i/Kconfig
@@ -1,6 +1,8 @@
config SCSI_BNX2_ISCSI
tristate "Broadcom NetXtreme II iSCSI support"
select SCSI_ISCSI_ATTRS
+ select NETDEVICES
+ select NETDEV_1000
select CNIC
depends on PCI
---help---
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] bnx2i/cnic: kconfig interactions
2009-06-18 16:55 ` [PATCH -next] bnx2i/cnic: kconfig interactions Randy Dunlap
@ 2009-06-18 18:39 ` Michael Chan
0 siblings, 0 replies; 2+ messages in thread
From: Michael Chan @ 2009-06-18 18:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next@vger.kernel.org, LKML, Sam Ravnborg,
Anil Veerabhadrappa, scsi, James Bottomley
On Thu, 2009-06-18 at 09:55 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> NETDEVICES + NETDEV_1000 need to be enabled so that kconfig will check
> those branches for selects and enforce "select UIO" under CNIC.
> Otherwise the build fails with:
I think this patch is better than your previous patch to select UIO.
Other iSCSI drivers that select net drivers will probably need something
similar too.
Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>
>
> ERROR: "uio_unregister_device" [drivers/net/cnic.ko] undefined!
> ERROR: "uio_event_notify" [drivers/net/cnic.ko] undefined!
> ERROR: "__uio_register_device" [drivers/net/cnic.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
> Cc: Michael Chan <mchan@broadcom.com>
> ---
> drivers/scsi/bnx2i/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20090618.orig/drivers/scsi/bnx2i/Kconfig
> +++ linux-next-20090618/drivers/scsi/bnx2i/Kconfig
> @@ -1,6 +1,8 @@
> config SCSI_BNX2_ISCSI
> tristate "Broadcom NetXtreme II iSCSI support"
> select SCSI_ISCSI_ATTRS
> + select NETDEVICES
> + select NETDEV_1000
> select CNIC
> depends on PCI
> ---help---
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-18 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090618145949.d933719a.sfr@canb.auug.org.au>
2009-06-18 16:55 ` [PATCH -next] bnx2i/cnic: kconfig interactions Randy Dunlap
2009-06-18 18:39 ` Michael Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox