From: James Smart <James.Smart@Emulex.Com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lpfc: Read buffer overflow
Date: Mon, 3 Aug 2009 11:02:37 -0400 [thread overview]
Message-ID: <4A76FC0D.7080005@emulex.com> (raw)
In-Reply-To: <4A754999.90208@gmail.com>
NACK - the vports array is created such that it is sized for
phba->max_vports + 1.
-- james s
Roel Kluin wrote:
> Check whether index is within bounds before testing the element.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/scsi/lpfc/lpfc_vport.c b/drivers/scsi/lpfc/lpfc_vport.c
> index e0b4992..ade2df6 100644
> --- a/drivers/scsi/lpfc/lpfc_vport.c
> +++ b/drivers/scsi/lpfc/lpfc_vport.c
> @@ -762,7 +762,7 @@ lpfc_destroy_vport_work_array(struct lpfc_hba *phba, struct lpfc_vport **vports)
> int i;
> if (vports == NULL)
> return;
> - for (i = 0; vports[i] != NULL && i <= phba->max_vports; i++)
> + for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++)
> scsi_host_put(lpfc_shost_from_vport(vports[i]));
> kfree(vports);
> }
>
>
next prev parent reply other threads:[~2009-08-03 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 8:08 [PATCH] lpfc: Read buffer overflow Roel Kluin
2009-08-03 15:02 ` James Smart [this message]
2009-08-03 17:15 ` Joe Eykholt
2009-08-04 13:29 ` James Smart
2009-08-03 23:42 ` Andrew Morton
2009-08-04 0:31 ` James Bottomley
2009-08-04 13:39 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A76FC0D.7080005@emulex.com \
--to=james.smart@emulex.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox