[PATCH 1/1] scsi_error.c : reservation conflict after timeout causes device to be taken offline

[PATCH 1/1] scsi_error.c : reservation conflict after timeout causes device to be taken offline

[Michael Reed]

An IBM tape drive failed to complete a PERSISTENT RESERVE IN within the scsi cmd
timeout.  Error recovery was initiated and it sequenced from abort through taking
the tape drive offline.

The device was taken offline because it repeatedly responded to the TUR command
issued by error recovery with a RESERVATION CONFLICT status.  The tape drive
was reserved to another system.  This is perfectly legitimate response to TUR,
and is one that an escalation of recovery is unlikely to clear.  Further,
escalation of recovery can have undesirable side effects on the operation of
tape drives shared with other initiators.

Instead of escalating recovery, error recovery should treat the RESERVATION
CONFLICT response to the TUR as a good status, giving the issuer of the
command the opportunity to handle the timeout and reservation conflict.

Signed-off-by: Michael reed <mdr@sgi.com>

--


--- linux-2.6.30.4/drivers/scsi/scsi_error.c	2009-07-30 17:34:47.000000000 -0500
+++ linux-2.6.30.4-modified/drivers/scsi/scsi_error.c	2009-08-10 10:29:41.138433154 -0500
@@ -382,9 +382,13 @@ static int scsi_eh_completed_normally(st
 		 * who knows?  FIXME(eric)
 		 */
 		return SUCCESS;
+	case RESERVATION_CONFLICT:
+		/*
+		 * let issuer deal with this, it could be just fine
+		 */
+		return SUCCESS;
 	case BUSY:
 	case QUEUE_FULL:
-	case RESERVATION_CONFLICT:
 	default:
 		return FAILED;
 	}