Re: [RFC PATCH 3/9] drivers: convert drivers setting the change_queue_depth callback

[Jeff Garzik <jeff@garzik.org>]

On 08/26/2009 02:03 PM, Vasu Dev wrote:
> From: Mike Christie<michaelc@cs.wisc.edu>
>
> This is a simple port of the drivers setting a change_queue_depth
> callback but were not tracking queue fulls. In the patch I just have
> these LLDs adjust the queue depth if the user was requesting it.

Where is the doc describing how, and why, queue-full tracking occurs?


> diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
> index 86a4058..fb28be9 100644
> --- a/drivers/ata/sata_nv.c
> +++ b/drivers/ata/sata_nv.c
> @@ -1963,7 +1963,7 @@ static int nv_swncq_slave_config(struct scsi_device *sdev)
>   	ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num));
>
>   	if (strncmp(model_num, "Maxtor", 6) == 0) {
> -		ata_scsi_change_queue_depth(sdev, 1);
> +		ata_scsi_change_queue_depth(sdev, 1, SCSI_QDEPTH_SYSFS_REQ);
>   		ata_dev_printk(dev, KERN_NOTICE,
>   			"Disabling SWNCQ mode (depth %x)\n", sdev->queue_depth);
>   	}

This queue depth change was clearly not requested via sysfs...

	Jeff