From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 5/5] scsi_debug: Implement support for DIF Type 2 Date: Thu, 27 Aug 2009 17:20:26 +0300 Message-ID: <4A96962A.8050208@panasas.com> References: <1251267481-24135-1-git-send-email-martin.petersen@oracle.com> <1251267481-24135-6-git-send-email-martin.petersen@oracle.com> <4A952D54.5010102@panasas.com> <4A965366.7080409@panasas.com> <1251380478.6426.11.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from ip67-152-220-67.z220-152-67.customer.algx.net ([67.152.220.67]:53124 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752094AbZH0OU3 (ORCPT ); Thu, 27 Aug 2009 10:20:29 -0400 In-Reply-To: <1251380478.6426.11.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: "Martin K. Petersen" , linux-scsi@vger.kernel.org On 08/27/2009 04:41 PM, James Bottomley wrote: > > The general rule is not to confuse coding styles, so the correct way to > add stuff is to use the existing conventions in the file. You can > optionally convert the entire style if necessary. However, for these > get_cpu_be macros, there's no real benefit other than saving typing, so > a global conversion effort simply isn't worth it. > This is not right. The get_cpu_be macros are ten fold faster and smaller on all the platforms we ever use. I'm talking about 16-96 to 1 for a 64 bit operation. Not to mention the heart attack it gives me every time. Is that index go down or up? the shifts go bigger or smaller? even just for that I would wrap them, triple check, and never use anything else. But the stronger fact of the matter is that I don't think there is a single used ARCH that does shifts anymore. > James > > Boaz