From: Jiri Slaby <jirislaby@gmail.com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org,
Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: [PATCH] qla2xxx: Fix Null ptr dereference in fail path in queue create code
Date: Fri, 25 Sep 2009 09:48:36 +0200 [thread overview]
Message-ID: <4ABC75D4.1020207@gmail.com> (raw)
In-Reply-To: <alpine.OSX.1.00.0909250036530.1854@n4017av1qdvv31.qlogic.org>
On 09/25/2009 09:45 AM, Anirban Chakraborty wrote:
> Current code jumps to fail path in queue create functions and there it invokes
> the queue free call with a (NULL) pointer to the queue which could not be
> allocated. Fix it by returning ENOMEM directly without invoking the queue free
Sorry, staring at callers now. They expect 0 on error. So both my and
your patches are wrong in this manner. There should be 'return 0'.
prev parent reply other threads:[~2009-09-25 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 7:45 [PATCH] qla2xxx: Fix Null ptr dereference in fail path in queue create code Anirban Chakraborty
2009-09-25 7:48 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABC75D4.1020207@gmail.com \
--to=jirislaby@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=andrew.vasquez@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).