From: Mike Christie <michaelc@cs.wisc.edu>
To: kxie@chelsio.com
Cc: James.Bottomley@HansenPartnership.com, davem@davemloft.net,
swise@opengridcomputing.com, divy@chelsio.com,
rakesh@chelsio.com, linux-scsi@vger.kernel.org,
open-iscsi@googlegroups.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC address in iSCSI
Date: Fri, 25 Sep 2009 19:36:10 -0500 [thread overview]
Message-ID: <4ABD61FA.2040609@cs.wisc.edu> (raw)
In-Reply-To: <200909252225.n8PMPaa4031752@localhost.localdomain>
kxie@chelsio.com wrote:
> [PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI
>
> From: Karen Xie <kxie@chelsio.com>
>
> This patch updated the use of private MAC address per port in iscsi.
>
> This patch is generated against scsi-post-merge.
>
> Signed-off-by: Karen Xie <kxie@chelsio.com>
> ---
> drivers/scsi/cxgb3i/cxgb3i_offload.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> index 6a1d86b..f585ece 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
> +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> @@ -234,9 +234,9 @@ struct sge_opaque_hdr {
> * get and set private ip for iscsi traffic
> */
> #define cxgb3i_get_private_ipv4addr(ndev) \
> - (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
> + (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
> #define cxgb3i_set_private_ipv4addr(ndev, addr) \
> - (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
> + (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr
>
This looks ok.
Reviewed-by Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2009-09-26 0:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 22:25 [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC address in iSCSI kxie-ut6Up61K2wZBDgjK7y7TUQ
2009-09-26 0:36 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABD61FA.2040609@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=rakesh@chelsio.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).