* [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()
@ 2009-10-06 20:17 Roel Kluin
2009-10-13 23:40 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-10-06 20:17 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, Andrew Morton
Besides keeping the line short, the second setting of the
MR_DMA_MODE bit was removed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Please review, maybe some other bit should be set?
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index f92da9f..5d2f148 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
#endif
/* KLL May need eop and parity in 53c400 */
if (hostdata->flags & FLAG_NCR53C400)
- NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
+ NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
+ MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
+ MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
else
NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
#endif /* def REAL_DMA */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()
2009-10-06 20:17 [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma() Roel Kluin
@ 2009-10-13 23:40 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-10-13 23:40 UTC (permalink / raw)
To: Roel Kluin; +Cc: James E.J. Bottomley, linux-scsi, Alan Cox
On Tue, 06 Oct 2009 22:17:43 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Besides keeping the line short, the second setting of the
> MR_DMA_MODE bit was removed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Please review, maybe some other bit should be set?
The only ones left are MR_BLOCK_DMA_MODE and MR_ARBITRATE.
No, I don't know if they hould have been set either. Let that sleeping
dog lie, I suspect.
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index f92da9f..5d2f148 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
> #endif
> /* KLL May need eop and parity in 53c400 */
> if (hostdata->flags & FLAG_NCR53C400)
> - NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
> + NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
> + MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
> + MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
> else
> NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
> #endif /* def REAL_DMA */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 20:17 [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma() Roel Kluin
2009-10-13 23:40 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).