linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Sachin Sant <sachinp@in.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] drivers/ata/ahci build break.
Date: Fri, 09 Oct 2009 16:00:57 +0900	[thread overview]
Message-ID: <4ACEDFA9.9080102@kernel.org> (raw)
In-Reply-To: <20091009064638.GA27673@parisc-linux.org>

Matthew Wilcox wrote:
> The usual way to do this is to make sure there's a dummy
> ahci_gtf_filter_workaround so there doesn't have to be that ifdef in
> the caller.  This is probably easier to do like this:
> 
> @@ -2884,6 +2884,7 @@ static bool ahci_broken_online(struct pc
>  	return pdev->bus->number == (val >> 8) && pdev->devfn == (val & 0xff);
>  }
>  
>  static void ahci_gtf_filter_workaround(struct ata_host *host)
>  {
> +#ifdef CONFIG_ATA_ACPI
>  	static const struct dmi_system_id sysids[] = {
> @@ -2927,6 +2928,7 @@ static void ahci_gtf_filter_workaround(s
>  				dev->gtf_filter |= filter;
>  	}
> +#endif
>  }

Fix is already included in Jeff's tree.

Thanks.

-- 
tejun

  reply	other threads:[~2009-10-09  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09  6:27 [PATCH] drivers/ata/ahci build break Sachin Sant
2009-10-09  6:46 ` Matthew Wilcox
2009-10-09  7:00   ` Tejun Heo [this message]
2009-10-09  8:18     ` Sachin Sant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACEDFA9.9080102@kernel.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sachinp@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).