From: James Smart <James.Smart@Emulex.Com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: "James.Bottomley@suse.de" <James.Bottomley@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -repost 3/4] SCSI: lpfc, fix memory leak
Date: Fri, 9 Oct 2009 13:43:24 -0400 [thread overview]
Message-ID: <4ACF763C.5070308@emulex.com> (raw)
In-Reply-To: <1255096688-23399-3-git-send-email-jirislaby@gmail.com>
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Jiri Slaby wrote:
> Stanse found a memory leak on one fail path in lpfc_sli4_read_rev.
>
> Add there kfree.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: James Smart <james.smart@emulex.com>
> Cc: James E.J. Bottomley <James.Bottomley@suse.de>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 43cbe33..7750868 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -4211,6 +4211,7 @@ lpfc_sli4_read_rev(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq,
> if (rc) {
> dma_free_coherent(&phba->pcidev->dev, dma_size,
> dmabuf->virt, dmabuf->phys);
> + kfree(dmabuf);
> return -EIO;
> }
>
>
next prev parent reply other threads:[~2009-10-09 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 13:58 [PATCH -repost 1/4] SCSI: aacraid, fix memory leak Jiri Slaby
2009-10-09 13:58 ` [PATCH -repost 2/4] SCSI: remove unnecessary NULL test Jiri Slaby
2009-10-09 13:58 ` [PATCH -repost 3/4] SCSI: lpfc, fix memory leak Jiri Slaby
2009-10-09 17:43 ` James Smart [this message]
2009-10-09 13:58 ` [PATCH -repost 4/4] SCSI: scsi_lib, fix potential NULL dereference Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACF763C.5070308@emulex.com \
--to=james.smart@emulex.com \
--cc=James.Bottomley@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).