From: James Smart <James.Smart@Emulex.Com>
To: Michael Reed <mdr@sgi.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] remove invalid BUG_ON in scsi_transport_fc.c
Date: Tue, 13 Oct 2009 13:15:45 -0400 [thread overview]
Message-ID: <4AD4B5C1.7020909@emulex.com> (raw)
In-Reply-To: <4ACF8BEF.6040105@sgi.com>
This patch looks good. Thanks Mike.
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Michael Reed wrote:
> I was doing some large lun count testing with 2.6.31 and hit
> a BUG_ON() in fc_timeout_deleted_rport(), and it seems like it
> should have been just a matter of time before someone did.
>
> It seems invalid to set port_state under lock, then expect it to
> remain set after releasing the lock. Another thread called
> fc_remote_port_add() when the lock was released, changing the
> port_state.
>
> This patch removes the BUG_ON and moves the test of the
> port_state to inside the host_lock. It's been running for
> several weeks now with no ill effect.
>
> Applies to 2.6.31 and 2.6.32-rc3.
>
> Signed-off-by: Michael Reed <mdr@sgi.com>
>
>
> --- a/drivers/scsi/scsi_transport_fc.c 2009-09-09 17:13:59.000000000 -0500
> +++ b/drivers/scsi/scsi_transport_fc.c 2009-10-02 15:09:00.298487474 -0500
prev parent reply other threads:[~2009-10-13 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AB3D773.50108@sgi.com>
[not found] ` <4AB3DB7C.2050004@emulex.com>
[not found] ` <4AB3DE99.3080602@sgi.com>
2009-10-09 19:15 ` [PATCH 1/1] remove invalid BUG_ON in scsi_transport_fc.c Michael Reed
2009-10-13 17:15 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD4B5C1.7020909@emulex.com \
--to=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).