From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Subject: Re: [PATCH 1/6] ibmvfc: Fixup TMF response handling - drop Date: Mon, 19 Oct 2009 14:56:25 -0500 Message-ID: <4ADCC469.20205@linux.vnet.ibm.com> References: <200910191919.n9JJJhxV018480@d01av04.pok.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e38.co.us.ibm.com ([32.97.110.159]:41218 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbZJST4j (ORCPT ); Mon, 19 Oct 2009 15:56:39 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9JJqNIw008174 for ; Mon, 19 Oct 2009 13:52:23 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9JJuQk3082330 for ; Mon, 19 Oct 2009 13:56:26 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id n9JJuQTh011984 for ; Mon, 19 Oct 2009 13:56:26 -0600 In-Reply-To: <200910191919.n9JJJhxV018480@d01av04.pok.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James.Bottomley@HansenPartnership.com Cc: linux-scsi@vger.kernel.org James, Please drop this patch series, as it has a bug in the passthru patch. I'll resend the fixed patch series soon. Thanks, Brian Brian King wrote: > When processing the response to either a LUN reset, > target reset, or an abort task set, the ibmvfc driver needs to > treat as success receiving a response with a non-zero > status in the response IU along with a general transport > error with the FCP response code being zero. The VIOS > currently guarantees this cannot happen, but a future version > of VIOS may allow this to be returned, so ensure we handle > this response combination correctly for TMFs, as we already > do for SCSI commands. > > Signed-off-by: Brian King > --- > > drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff -puN drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_tmf_rsp_fixup drivers/scsi/ibmvscsi/ibmvfc.c > --- linux-2.6/drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_tmf_rsp_fixup 2009-10-02 10:39:48.000000000 -0500 > +++ linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvfc.c 2009-10-05 10:03:00.000000000 -0500 > @@ -1731,7 +1731,10 @@ static int ibmvfc_reset_device(struct sc > sdev_printk(KERN_INFO, sdev, "Resetting %s\n", desc); > wait_for_completion(&evt->comp); > > - if (rsp_iu.cmd.status) { > + if (rsp_iu.cmd.status) > + rsp_code = ibmvfc_get_err_result(&rsp_iu.cmd); > + > + if (rsp_code) { > if (fc_rsp->flags & FCP_RSP_LEN_VALID) > rsp_code = fc_rsp->data.info.rsp_code; > > @@ -1820,7 +1823,10 @@ static int ibmvfc_abort_task_set(struct > sdev_printk(KERN_INFO, sdev, "Aborting outstanding commands\n"); > wait_for_completion(&evt->comp); > > - if (rsp_iu.cmd.status) { > + if (rsp_iu.cmd.status) > + rsp_code = ibmvfc_get_err_result(&rsp_iu.cmd); > + > + if (rsp_code) { > if (fc_rsp->flags & FCP_RSP_LEN_VALID) > rsp_code = fc_rsp->data.info.rsp_code; > > _ -- Brian King Linux on Power Virtualization IBM Linux Technology Center