public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: Tim Small <tim@seoss.co.uk>
Cc: "Desai, Kashyap" <Kashyap.Desai@lsi.com>,
	"smartmontools-support@lists.sourceforge.net"
	<smartmontools-support@lists.sourceforge.net>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Linux-PowerEdge@dell.com" <Linux-PowerEdge@dell.com>,
	Gabor Gombas <gombasg@sztaki.hu>
Subject: Re: Apparent MPT ata pass-through bug SAS1068 and SAS1068E - WAS SMART causes disks to go offline on an LSI SAS1068 controller - Dell SAS 5/iR
Date: Wed, 28 Oct 2009 17:10:53 -0400	[thread overview]
Message-ID: <4AE8B35D.2070609@interlog.com> (raw)
In-Reply-To: <4AE877D3.4040300@seoss.co.uk>

Tim Small wrote:
> Desai, Kashyap wrote:
>> Can you try doing the same test upgrading our driver to 3.04.13?
>> You can find relevant patches at
>> http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fjejb%2Fscsi-misc-2.6.git&a=search&h=993340e8ab4e856bf0fc7818cdca1a92f6e8ed38&st=commit&s=kashyap 
>>
>>   
> 
> Have just compiled a kernel package from James' tree directly, rather 
> than attempting to back-port and manually patch, so I'm now running 
> 2.6.32-rc4 with mptsas 3.04.13.  I'm running the smartctl -a in a loop 
> at the moment and will leave it running over-night, but with this kernel 
> I get a pair of messages like this:
> 
> [ 1045.130560] scsi 2:0:0:0: [sg1] Sense Key : Recovered Error [current] 
> [descriptor]
> [ 1045.145751] Descriptor sense data with sense descriptors (in hex):
> [ 1045.158107]         72 01 00 1d 00 00 00 0e 09 0c 00 00 00 00 00 00
> [ 1045.171010]         00 4f 00 c2 00 50
> [ 1045.178585] scsi 2:0:0:0: [sg1] Add. Sense: ATA pass through 
> information available
> [ 1045.280318] scsi 2:0:0:0: [sg1] Sense Key : Recovered Error [current] 
> [descriptor]
> [ 1045.284311] Descriptor sense data with sense descriptors (in hex):
> [ 1045.284311]         72 01 00 1d 00 00 00 0e 09 0c 00 00 00 00 00 00
> [ 1045.284311]         00 4f 00 c2 00 50
> [ 1045.284311] scsi 2:0:0:0: [sg1] Add. Sense: ATA pass through 
> information available
> 
> for every 'smartctl -a /dev/sg1' command which is run.

Tim,
This is _not_ an error. If the CK_COND bit is set in the SCSI
ATA PASS-THROUGH (12 or 16 byte) cdb and the ATA command
succeeds then what is shown above is correct.

The whole point is to get the ATA registers after the command
is complete. The register values are placed in a ATA (status)
return descriptor encapsulated in sense data with that sense key
and those additional sense codes. The ATA return descriptor
starts with the "09" value in the sense buffer shown above.

smartmontools needs to set CK_COND on some ATA commands (e.g.
to get the SMART status) because the result can only be found
in the ATA registers after completion.

Now it is annoying, distracting and wasteful to log the sense
data in this particular situation. Perhaps the SCSI mid level
error reporting should filter out that particular combination:
   Sense key: RECOVERED ERROR
   Additional sense: ATA PASS THROUGH INFORMATION AVAILABLE (0x0,0x1d)

References: sat-r09.pdf sat2r09.pdf


Doug Gilbert

  reply	other threads:[~2009-10-28 21:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 14:29 SMART causes disks to go offline on an LSI SAS 1068 controller Gabor Gombas
2009-10-27 17:30 ` [smartmontools-support] SMART causes disks to go offline on an LSI SAS1068 controller - Dell SAS 5/iR Tim Small
2009-10-28 13:18   ` Apparent MPT ata pass-through bug SAS1068 and SAS1068E - WAS " Tim Small
2009-10-28 13:28     ` Desai, Kashyap
2009-10-28 16:56       ` Tim Small
2009-10-28 21:10         ` Douglas Gilbert [this message]
2009-10-29  8:59           ` [smartmontools-support] " Tim Small
2009-10-29  9:01         ` Tim Small
2009-10-29  9:55           ` [smartmontools-support] " Tim Small

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE8B35D.2070609@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=Kashyap.Desai@lsi.com \
    --cc=Linux-PowerEdge@dell.com \
    --cc=gombasg@sztaki.hu \
    --cc=linux-scsi@vger.kernel.org \
    --cc=smartmontools-support@lists.sourceforge.net \
    --cc=tim@seoss.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox