[PATCH] Add missing #include for include/scsi/osd_protocol.h

[PATCH] Add missing #include for include/scsi/osd_protocol.h

[Martin Michlmayr]

include/scsi/osd_protocol.h is missing an #include, leading to:
| include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
| include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'

Signed-off-by: Martin Michlmayr <tbm@cyrius.com>

--- a/include/scsi/osd_protocol.h	2009-10-31 09:19:28.000000000 +0000
+++ b/include/scsi/osd_protocol.h	2009-10-31 09:27:42.000000000 +0000
@@ -17,6 +17,7 @@
 #define __OSD_PROTOCOL_H__
 
 #include <linux/types.h>
+#include <linux/kernel.h>
 #include <asm/unaligned.h>
 #include <scsi/scsi.h>
 

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Boaz Harrosh]

On 10/31/2009 11:33 AM, Martin Michlmayr wrote:
> include/scsi/osd_protocol.h is missing an #include, leading to:
> | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
> | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
> 

I cannot reproduce this problem. What platform  (ARCH/config) are you compiling
this?

Because you see I have a source file in the tree that has this #include as very
first include. And it has been compiling in Kernel and in -next for a long time.
(drivers/scsi/osd/osd_initiator.c has osd_initiator.h as first header which has
 osd_protocol.h as first header.)

> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> 
> --- a/include/scsi/osd_protocol.h	2009-10-31 09:19:28.000000000 +0000
> +++ b/include/scsi/osd_protocol.h	2009-10-31 09:27:42.000000000 +0000
> @@ -17,6 +17,7 @@
>  #define __OSD_PROTOCOL_H__
>  
>  #include <linux/types.h>
> +#include <linux/kernel.h>
>  #include <asm/unaligned.h>

>From what I can see, asm/unaligned.h eventually pulls kernel.h through
one of it's possible implementations. Do you have a special asm/unaligned.h?

>  #include <scsi/scsi.h>
>  
> 

Please help me reproduce this problem.

Boaz

Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Martin Michlmayr]

* Boaz Harrosh <bharrosh@panasas.com> [2009-11-01 12:15]:
> > include/scsi/osd_protocol.h is missing an #include, leading to:
> > | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
> > | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
> 
> I cannot reproduce this problem. What platform  (ARCH/config) are you compiling
> this?

Sorry, I forgot to say that this happens on ARM.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Boaz Harrosh]

On 11/01/2009 12:54 PM, Martin Michlmayr wrote:
> * Boaz Harrosh <bharrosh@panasas.com> [2009-11-01 12:15]:
>>> include/scsi/osd_protocol.h is missing an #include, leading to:
>>> | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
>>> | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
>>
>> I cannot reproduce this problem. What platform  (ARCH/config) are you compiling
>> this?
> 
> Sorry, I forgot to say that this happens on ARM.

Yes I can see now linux/unaligned/le_byteshift.h and linux/unaligned/be_byteshift.h look
broken, they do not include headers who's definitions are used. All the other alternatives
in linux/unaligned/ ,example access_ok.h, do. Sigh

But one thing I do not understand, in linux-next is there not a single ARM platform that
does a "make allmodconfig". (Or they do but the compilation error was never reported?)

ACK-by: Boaz Harrosh <bharrosh@panasas.com>

Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Hi Boaz,

On Sun, 01 Nov 2009 13:25:43 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> Yes I can see now linux/unaligned/le_byteshift.h and linux/unaligned/be_byteshift.h look
> broken, they do not include headers who's definitions are used. All the other alternatives
> in linux/unaligned/ ,example access_ok.h, do. Sigh
> 
> But one thing I do not understand, in linux-next is there not a single ARM platform that
> does a "make allmodconfig". (Or they do but the compilation error was never reported?)

The arm allmodconfig is really a non starter I am told (allmodconfig is
really per arch, not per platform).  However you can see all the
linux-next build results for arm (and lots of others) at
http://kisskb.ellerman.id.au/kisskb/branch/9/ .  I often don't have time
to review the build results - I assume that other people with an interest
will do so.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Boaz Harrosh]

On 11/01/2009 01:52 PM, Stephen Rothwell wrote:
> Hi Boaz,
> 
> On Sun, 01 Nov 2009 13:25:43 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> Yes I can see now linux/unaligned/le_byteshift.h and linux/unaligned/be_byteshift.h look
>> broken, they do not include headers who's definitions are used. All the other alternatives
>> in linux/unaligned/ ,example access_ok.h, do. Sigh
>>
>> But one thing I do not understand, in linux-next is there not a single ARM platform that
>> does a "make allmodconfig". (Or they do but the compilation error was never reported?)
> 
> The arm allmodconfig is really a non starter I am told (allmodconfig is
> really per arch, not per platform).  However you can see all the
> linux-next build results for arm (and lots of others) at
> http://kisskb.ellerman.id.au/kisskb/branch/9/ .  I often don't have time
> to review the build results - I assume that other people with an interest
> will do so.
> 

>From the list you've sent (above), there is not a single ARM platform
that does an allXXXconfig. They are all a "defconfig". I'll bear that
in mind next time.

(Time for that arm cross compiler)

Thanks
Boaz