From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: James Bottomley <James.Bottomley@suse.de>
Cc: "Penchala Narasimha Reddy Chilakala,
TLS-Chennai" <narasimhareddyc@hcl.in>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
ServeRAID Driver <ServeRAIDDriver@hcl.in>
Subject: Re: [PATCH ] scsi-misc-2.6: File System going into read-only mode
Date: Wed, 04 Nov 2009 02:40:04 +0100 [thread overview]
Message-ID: <4AF0DB74.8010906@s5r6.in-berlin.de> (raw)
In-Reply-To: <4AF0D9CE.2050407@s5r6.in-berlin.de>
Stefan Richter wrote:
> Stefan Richter wrote:
>> Before:
>>
>> if (upsg->sg[i].count > (dev->adapter_info.options & AAC_OPT_NEW_COMM)
>> ? (dev->scsi_host_ptr->max_sectors << 9) : 65536) {
>
> Doesn't make sense. dev->adapter_info.options is a __le32 bitfield.
>
>> After:
>>
>> if (upsg->sg[i].count > (
>> (dev->adapter_info.options & AAC_OPT_NEW_COMM)
>> ? (dev->scsi_host_ptr->max_sectors << 9) : 65536
>> )) {
>
> Makes sense. Don't know if it's correct.
PS: These things wouldn't happen if
a) the coding wouldn't be as deeply nested,
b) sparse with endianess check would be used for QA.
(OK, it's apparently a decade old code.)
--
Stefan Richter
-=====-==--= =-== --=--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-11-04 1:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 8:47 [PATCH ] scsi-misc-2.6: File System going into read-only mode Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-09-29 14:19 ` James Bottomley
2009-09-30 11:09 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-09-30 11:33 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-10-07 6:02 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-02 17:46 ` James Bottomley
2009-11-03 10:17 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-03 14:40 ` James Bottomley
2009-11-04 1:23 ` Stefan Richter
2009-11-04 1:33 ` Stefan Richter
2009-11-04 1:40 ` Stefan Richter [this message]
2009-11-04 6:44 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-04 7:21 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-04 15:30 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2009-10-09 9:23 Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-10-22 1:09 ` James Bottomley
2009-10-23 13:10 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-02 7:35 Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-02 16:30 ` Stefan Richter
2009-11-03 9:54 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-03 19:02 ` Stefan Richter
2009-11-04 7:00 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-04 9:18 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-04 14:48 ` Stefan Richter
2009-11-02 17:45 ` James Bottomley
2009-11-03 9:38 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-03 15:08 ` James Bottomley
2009-11-04 7:07 ` Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-04 15:42 ` James Bottomley
2009-11-05 13:27 Penchala Narasimha Reddy Chilakala, TLS-Chennai
2009-11-11 19:26 ` James Bottomley
2009-11-12 8:28 ` Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-11-13 20:55 ` James Bottomley
2009-11-16 3:25 ` Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-11-16 15:51 ` James Bottomley
2009-11-17 5:22 ` Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-11-17 5:27 ` Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-12-18 12:25 Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-12-21 13:09 Penchala Narasimha Reddy Chilakala, ERS-HCLTech
2009-12-24 6:29 Penchala Narasimha Reddy Chilakala, ERS-HCLTech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF0DB74.8010906@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@suse.de \
--cc=ServeRAIDDriver@hcl.in \
--cc=linux-scsi@vger.kernel.org \
--cc=narasimhareddyc@hcl.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox