public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: John Hughes <john@Calva.COM>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: ses enclosure stuff not working with Promise Vtrak J610S JBOD
Date: Wed, 04 Nov 2009 19:10:01 +0100	[thread overview]
Message-ID: <4AF1C379.7060306@Calva.COM> (raw)
In-Reply-To: <1257357948.10416.9.camel@mulgrave.site>

James Bottomley wrote:
> On Wed, 2009-11-04 at 19:01 +0100, John Hughes wrote:
>   
>>
>> diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
>> index 55b034b..725a095 100644
>> --- a/drivers/scsi/ses.c
>> +++ b/drivers/scsi/ses.c
>> @@ -389,9 +389,9 @@ static void ses_enclosure_data_process(struct enclosure_devi
>>                 len = (desc_ptr[2] << 8) + desc_ptr[3];
>>                 /* skip past overall descriptor */
>>                 desc_ptr += len + 4;
>> -               if (ses_dev->page10)
>> -                       addl_desc_ptr = ses_dev->page10 + 8;
>>         }
>> +       if (ses_dev->page10)
>> +               addl_desc_ptr = ses_dev->page10 + 8;
>>     
>
> Ah, yes ... knew I'd done something stupid.
>
> Could you format this properly (as in with description) and add a signed
> off by line and I'll put it in the bug fixes tree.
>   
I'll do that tomorrow, off home to play some fallout3 now.

(Well, and feed the kids).

  reply	other threads:[~2009-11-04 18:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 13:00 ses enclosure stuff not working with Promise Vtrak J610S JBOD John Hughes
2009-11-04 15:17 ` John Hughes
2009-11-04 15:22 ` James Bottomley
2009-11-04 15:53   ` John Hughes
2009-11-04 16:07     ` James Bottomley
2009-11-04 16:12       ` John Hughes
2009-11-04 16:20         ` James Bottomley
2009-11-04 18:01           ` John Hughes
2009-11-04 18:05             ` James Bottomley
2009-11-04 18:10               ` John Hughes [this message]
2009-11-05  9:41             ` John Hughes
2009-11-05 15:30               ` John Hughes
2009-11-05 15:44                 ` James Bottomley
2009-11-04 15:51 ` John Hughes
2009-11-04 16:54   ` John Hughes
2009-11-04 16:55   ` John Hughes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF1C379.7060306@Calva.COM \
    --to=john@calva.com \
    --cc=James.Bottomley@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox