From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] zfcp: Test kmalloc failure in scsi_get_vpd_page()
Date: Thu, 05 Nov 2009 10:29:03 +0200
Message-ID: <4AF28CCF.8020605@panasas.com>
References: <4A92BE18.50208@gmail.com>	 <1251416731.27356.8.camel@mulgrave.site>  <4A9A6676.8050304@panasas.com>	 <1251642902.10135.4.camel@mulgrave.site>	 <1257273187.9427.22.camel@mulgrave.site>  <4AF14147.4050102@panasas.com>	 <1257347360.2697.20.camel@mulgrave.site>  <4AF1A941.3080808@panasas.com> <1257357013.10416.8.camel@mulgrave.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from dip-colo-pa.panasas.com ([67.152.220.67]:13570 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1755343AbZKEI3D (ORCPT
	<rfc822;linux-scsi@vger.kernel.org>); Thu, 5 Nov 2009 03:29:03 -0500
In-Reply-To: <1257357013.10416.8.camel@mulgrave.site>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: James Bottomley <James.Bottomley@suse.de>
Cc: Roel Kluin <roel.kluin@gmail.com>, linux-scsi@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, "Martin K. Petersen" <martin.petersen@oracle.com>

On 11/04/2009 07:50 PM, James Bottomley wrote:
> On Wed, 2009-11-04 at 18:18 +0200, Boaz Harrosh wrote:
> 
> The point of checking is not to send a VPD inquiry to USB devices that
> don't support it.  These have a very limited range of supported VPD
> pages.
> 

OK thanks. But maybe just define a MIN_INQUIRY_SIZE instead of hard
coded 32 everywhere, and use that. So in future if such a device is
found we can easily change it.

(Never say never ;-))


> James
> 
> 

Boaz