From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 4/4] be2iscsi: code reorganizing and minor changes
Date: Thu, 19 Nov 2009 15:55:13 -0600 [thread overview]
Message-ID: <4B05BEC1.9060203@cs.wisc.edu> (raw)
In-Reply-To: <20091118004345.GA10344@serverengines.com>
Jayamohan Kallickal wrote:
> This patch does a couple of very small, mostly
> single line changes which I feel will be an overkill to put in
> individual patches
>
> 1) moved pci_set_drvdata to inside beiscsi_hba_alloc
> 2) Enabled handling of TEXT Response
> 3) Added opcode for ISCSI_OP_LOGOUT_RSP, ISCSI_OP_SCSI_TMFUNC_RSP,
> 4) Ask for ack based completion for NOOPOUT and TTT != RESERVERD
>
I think in the future you still might want to separate these.
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index ac76b14..109482f 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -564,6 +565,8 @@ beiscsi_process_async_pdu(struct beiscsi_conn *beiscsi_conn,
> login_hdr = (struct iscsi_hdr *)ppdu;
> login_hdr->itt = io_task->libiscsi_itt;
> break;
> + case ISCSI_OP_TEXT_RSP:
> + break;
Is this the only thing needed for TEXT pdu handling? Did you test with
my userspace changes and the libiscsi fixups?
next prev parent reply other threads:[~2009-11-19 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 0:43 [PATCH 4/4] be2iscsi: code reorganizing and minor changes Jayamohan Kallickal
2009-11-18 9:18 ` [PATCH 4/5] pm8001: misc fixes and minor code cleanup jack wang
2009-11-18 9:18 ` [PATCH 5/5] pm8001: set SSC down-spreading only to get less errors on some 6G device jack wang
2009-11-19 21:55 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-19 22:23 [PATCH 4/4] be2iscsi: code reorganizing and minor changes Jayamohan Kalickal
2009-11-19 22:38 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B05BEC1.9060203@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).