* [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
@ 2009-12-07 19:39 Anil Veerabhadrappa
2009-12-10 2:45 ` Mike Christie
0 siblings, 1 reply; 4+ messages in thread
From: Anil Veerabhadrappa @ 2009-12-07 19:39 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, open-iscsi, michaelc, mchan, poswald
* Add code to enumerate 5771E device
Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
---
drivers/scsi/bnx2i/bnx2i_init.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 0c4210d..3c46458 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -83,8 +83,12 @@ void bnx2i_identify_device(struct bnx2i_hba *hba)
set_bit(BNX2I_NX2_DEV_5709, &hba->cnic_dev_type);
hba->mail_queue_access = BNX2I_MQ_BIN_MODE;
} else if (hba->pci_did == PCI_DEVICE_ID_NX2_57710 ||
- hba->pci_did == PCI_DEVICE_ID_NX2_57711)
+ hba->pci_did == PCI_DEVICE_ID_NX2_57711 ||
+ hba->pci_did == PCI_DEVICE_ID_NX2_57711E)
set_bit(BNX2I_NX2_DEV_57710, &hba->cnic_dev_type);
+ else
+ printk(KERN_ALERT "bnx2i: unknown device, 0x%x\n",
+ hba->pci_did);
}
--
1.6.5.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
2009-12-07 19:39 [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver Anil Veerabhadrappa
@ 2009-12-10 2:45 ` Mike Christie
2009-12-10 15:43 ` James Bottomley
0 siblings, 1 reply; 4+ messages in thread
From: Mike Christie @ 2009-12-10 2:45 UTC (permalink / raw)
To: Anil Veerabhadrappa
Cc: James.Bottomley, linux-scsi, open-iscsi, mchan, poswald
Anil Veerabhadrappa wrote:
> * Add code to enumerate 5771E device
>
> Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 0c4210d..3c46458 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -83,8 +83,12 @@ void bnx2i_identify_device(struct bnx2i_hba *hba)
> set_bit(BNX2I_NX2_DEV_5709, &hba->cnic_dev_type);
> hba->mail_queue_access = BNX2I_MQ_BIN_MODE;
> } else if (hba->pci_did == PCI_DEVICE_ID_NX2_57710 ||
> - hba->pci_did == PCI_DEVICE_ID_NX2_57711)
> + hba->pci_did == PCI_DEVICE_ID_NX2_57711 ||
> + hba->pci_did == PCI_DEVICE_ID_NX2_57711E)
> set_bit(BNX2I_NX2_DEV_57710, &hba->cnic_dev_type);
> + else
> + printk(KERN_ALERT "bnx2i: unknown device, 0x%x\n",
> + hba->pci_did);
> }
>
>
Ok.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
2009-12-10 2:45 ` Mike Christie
@ 2009-12-10 15:43 ` James Bottomley
2009-12-10 18:24 ` Anil Veerabhadrappa
0 siblings, 1 reply; 4+ messages in thread
From: James Bottomley @ 2009-12-10 15:43 UTC (permalink / raw)
To: Mike Christie; +Cc: Anil Veerabhadrappa, linux-scsi, open-iscsi, mchan, poswald
On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote:
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
But not by checkpatch:
ERROR: trailing whitespace
#23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90:
+^I^Iprintk(KERN_ALERT "bnx2i: unknown device, 0x%x\n", $
total: 1 errors, 0 warnings, 13 lines checked
I've fixed it up. And the several other whitespace problems in the rest
of the patch set.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
2009-12-10 15:43 ` James Bottomley
@ 2009-12-10 18:24 ` Anil Veerabhadrappa
0 siblings, 0 replies; 4+ messages in thread
From: Anil Veerabhadrappa @ 2009-12-10 18:24 UTC (permalink / raw)
To: James Bottomley
Cc: Mike Christie, linux-scsi@vger.kernel.org,
open-iscsi@googlegroups.com, Michael Chan, poswald@novell.com
On Thu, 2009-12-10 at 07:43 -0800, James Bottomley wrote:
> On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote:
> > Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
>
> But not by checkpatch:
>
> ERROR: trailing whitespace
> #23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90:
> +^I^Iprintk(KERN_ALERT "bnx2i: unknown device, 0x%x\n", $
>
> total: 1 errors, 0 warnings, 13 lines checked
>
> I've fixed it up. And the several other whitespace problems in the rest
> of the patch set.
>
Thanks James. In future will make sure not to repeat the slip-up.
Thanks again.
> James
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-10 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 19:39 [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver Anil Veerabhadrappa
2009-12-10 2:45 ` Mike Christie
2009-12-10 15:43 ` James Bottomley
2009-12-10 18:24 ` Anil Veerabhadrappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox