Re: [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified

[Mike Christie <michaelc@cs.wisc.edu>]

Anil Veerabhadrappa wrote:
>     * This issue was discovered during 10G iscsi testing
>     * Default value of 'sq_size' module parameter is '0' which means
>       driver should use predefined SQ queue size when setting up iscsi
>       connection.
>     * roundup_pow_of_two(0) results in '1' and forces driver to setup
>       connections with send queue size of '1' and results in lower
>       performance as well
> 
> Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
> ---
>  drivers/scsi/bnx2i/bnx2i_init.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 3c46458..dc6b56c 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -367,7 +367,7 @@ static int __init bnx2i_mod_init(void)
>  
>  	printk(KERN_INFO "%s", version);
>  
> -	if (!is_power_of_2(sq_size))
> +	if (sq_size && !is_power_of_2(sq_size))
>  		sq_size = roundup_pow_of_two(sq_size);
>  
>  	mutex_init(&bnx2i_dev_lock);

Ok.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>