* [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified
@ 2009-12-07 19:39 Anil Veerabhadrappa
2009-12-10 2:45 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Anil Veerabhadrappa @ 2009-12-07 19:39 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, open-iscsi, michaelc, mchan, poswald
* This issue was discovered during 10G iscsi testing
* Default value of 'sq_size' module parameter is '0' which means
driver should use predefined SQ queue size when setting up iscsi
connection.
* roundup_pow_of_two(0) results in '1' and forces driver to setup
connections with send queue size of '1' and results in lower
performance as well
Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
---
drivers/scsi/bnx2i/bnx2i_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 3c46458..dc6b56c 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -367,7 +367,7 @@ static int __init bnx2i_mod_init(void)
printk(KERN_INFO "%s", version);
- if (!is_power_of_2(sq_size))
+ if (sq_size && !is_power_of_2(sq_size))
sq_size = roundup_pow_of_two(sq_size);
mutex_init(&bnx2i_dev_lock);
--
1.6.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified
2009-12-07 19:39 [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified Anil Veerabhadrappa
@ 2009-12-10 2:45 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2009-12-10 2:45 UTC (permalink / raw)
To: open-iscsi; +Cc: James.Bottomley, linux-scsi, mchan, poswald
Anil Veerabhadrappa wrote:
> * This issue was discovered during 10G iscsi testing
> * Default value of 'sq_size' module parameter is '0' which means
> driver should use predefined SQ queue size when setting up iscsi
> connection.
> * roundup_pow_of_two(0) results in '1' and forces driver to setup
> connections with send queue size of '1' and results in lower
> performance as well
>
> Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 3c46458..dc6b56c 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -367,7 +367,7 @@ static int __init bnx2i_mod_init(void)
>
> printk(KERN_INFO "%s", version);
>
> - if (!is_power_of_2(sq_size))
> + if (sq_size && !is_power_of_2(sq_size))
> sq_size = roundup_pow_of_two(sq_size);
>
> mutex_init(&bnx2i_dev_lock);
Ok.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-10 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 19:39 [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified Anil Veerabhadrappa
2009-12-10 2:45 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox