From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org,
mchan@broadcom.com, poswald@novell.com
Subject: Re: [PATCH 5/5] BNX2I - minor code cleanup and update driver version
Date: Wed, 09 Dec 2009 20:46:16 -0600 [thread overview]
Message-ID: <4B2060F8.3090904@cs.wisc.edu> (raw)
In-Reply-To: <1260214839.31468.100.camel@anilgv-desktop>
Anil Veerabhadrappa wrote:
> * Removed duplicate function call and not-so-useful comment line
>
> Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 4 ++--
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index ad551c5..1e111ac 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -17,8 +17,8 @@ static struct list_head adapter_list = LIST_HEAD_INIT(adapter_list);
> static u32 adapter_count;
>
> #define DRV_MODULE_NAME "bnx2i"
> -#define DRV_MODULE_VERSION "2.0.1e"
> -#define DRV_MODULE_RELDATE "June 22, 2009"
> +#define DRV_MODULE_VERSION "2.1.0"
> +#define DRV_MODULE_RELDATE "Dec 06, 2009"
>
> static char version[] __devinitdata =
> "Broadcom NetXtreme II iSCSI Driver " DRV_MODULE_NAME \
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 070118a..54dc251 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -485,7 +485,6 @@ static int bnx2i_setup_cmd_pool(struct bnx2i_hba *hba,
> struct iscsi_task *task = session->cmds[i];
> struct bnx2i_cmd *cmd = task->dd_data;
>
> - /* Anil */
> task->hdr = &cmd->hdr;
> task->hdr_max = sizeof(struct iscsi_hdr);
>
> @@ -765,7 +764,6 @@ struct bnx2i_hba *bnx2i_alloc_hba(struct cnic_dev *cnic)
> hba->pci_svid = hba->pcidev->subsystem_vendor;
> hba->pci_func = PCI_FUNC(hba->pcidev->devfn);
> hba->pci_devno = PCI_SLOT(hba->pcidev->devfn);
> - bnx2i_identify_device(hba);
>
> bnx2i_identify_device(hba);
> bnx2i_setup_host_queue_size(hba, shost);
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2009-12-10 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 19:40 [PATCH 5/5] BNX2I - minor code cleanup and update driver version Anil Veerabhadrappa
2009-12-10 2:46 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2060F8.3090904@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=open-iscsi@googlegroups.com \
--cc=poswald@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox